Hi,
There are just two minor fixes from Hector that we've been carrying downstream for a while now. One increases the timeout while waiting for the firmware to boot which is optional for the controller already supported upstream but required for a newer 4388 board for which we'll also submit support soon. It also fixes the units for the timeouts which is why I've already included it here. The other one fixes a call to bitmap_release_region where we only wanted to release a single bit but are actually releasing much more.
Best,
Sven
To: Hector Martin marcan@marcan.st To: Alyssa Rosenzweig alyssa@rosenzweig.io To: Marcel Holtmann marcel@holtmann.org To: Luiz Augusto von Dentz luiz.dentz@gmail.com Cc: asahi@lists.linux.dev Cc: linux-arm-kernel@lists.infradead.org Cc: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Sven Peter sven@svenpeter.dev
Changes in v2: - split the timeout commit into two - collect Neal's tag - Link to v1: https://lore.kernel.org/r/20240512-btfix-msgid-v1-0-ab1bd938a7f4@svenpeter.d...
--- Hector Martin (2): Bluetooth: hci_bcm4377: Increase boot timeout Bluetooth: hci_bcm4377: Fix msgid release
Sven Peter (1): Bluetooth: hci_bcm4377: Use correct unit for timeouts
drivers/bluetooth/hci_bcm4377.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- base-commit: cf87f46fd34d6c19283d9625a7822f20d90b64a4 change-id: 20240512-btfix-msgid-d76029a7d917
Best regards,
From: Hector Martin marcan@marcan.st
We are releasing a single msgid, so the order argument to bitmap_release_region must be zero.
Fixes: 8a06127602de ("Bluetooth: hci_bcm4377: Add new driver for BCM4377 PCIe boards") Cc: stable@vger.kernel.org Signed-off-by: Hector Martin marcan@marcan.st Reviewed-by: Sven Peter sven@svenpeter.dev Reviewed-by: Neal Gompa neal@gompa.dev Signed-off-by: Sven Peter sven@svenpeter.dev --- drivers/bluetooth/hci_bcm4377.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c index 5b818a0e33d6..92d734f02e00 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -717,7 +717,7 @@ static void bcm4377_handle_ack(struct bcm4377_data *bcm4377, ring->events[msgid] = NULL; }
- bitmap_release_region(ring->msgids, msgid, ring->n_entries); + bitmap_release_region(ring->msgids, msgid, 0);
unlock: spin_unlock_irqrestore(&ring->lock, flags);
Hello:
This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz luiz.von.dentz@intel.com:
On Wed, 15 May 2024 18:15:01 +0000 you wrote:
Hi,
There are just two minor fixes from Hector that we've been carrying downstream for a while now. One increases the timeout while waiting for the firmware to boot which is optional for the controller already supported upstream but required for a newer 4388 board for which we'll also submit support soon. It also fixes the units for the timeouts which is why I've already included it here. The other one fixes a call to bitmap_release_region where we only wanted to release a single bit but are actually releasing much more.
[...]
Here is the summary with links: - [v2,1/3] Bluetooth: hci_bcm4377: Use correct unit for timeouts https://git.kernel.org/bluetooth/bluetooth-next/c/9ee7beea5921 - [v2,2/3] Bluetooth: hci_bcm4377: Increase boot timeout https://git.kernel.org/bluetooth/bluetooth-next/c/710a05bcfd4a - [v2,3/3] Bluetooth: hci_bcm4377: Fix msgid release https://git.kernel.org/bluetooth/bluetooth-next/c/bb0e96ccc834
You are awesome, thank you!
linux-stable-mirror@lists.linaro.org
-
patchwork-bot+bluetooth＠kernel.org -
Sven Peter via B4 Relay