On Wed, Aug 30, 2023 at 08:33:42AM -0700, Nathan Chancellor wrote:

Hi Greg and Sasha,

Please consider applying commit 9451c79bc39e ("powerpc/pmac/smp: Avoid unused-variable warnings") to 5.4, as it resolves a build failure that we see building ppc64_guest_defconfig with clang due to arch/powerpc compiling with -Werror by default:

arch/powerpc/platforms/powermac/smp.c:664:26: error: unused variable 'core99_l2_cache' [-Werror,-Wunused-variable] 664 | volatile static long int core99_l2_cache; | ^~~~~~~~~~~~~~~ arch/powerpc/platforms/powermac/smp.c:665:26: error: unused variable 'core99_l3_cache' [-Werror,-Wunused-variable] 665 | volatile static long int core99_l3_cache; | ^~~~~~~~~~~~~~~ 2 errors generated.

I have verified that it applies cleanly and does not appear to have any direct follow up fixes, although commit a4037d1f1fc4 ("powerpc/pmac/smp: Drop unnecessary volatile qualifier") was in the same area around the same time so maybe it makes sense to take that one as well but I don't think it has any functional impact.

Now queued up.

greg k-h