Add memory-region-names property for stm32mp257f-ev1. This allows to identify and check memory-map area's configuration.
Cc: stable@vger.kernel.org Fixes: cad2492de91c ("arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board")
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com --- arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -197,6 +197,7 @@ &i2c8 {
&ommanager { memory-region = <&mm_ospi1>; + memory-region-names = "mm_ospi1"; pinctrl-0 = <&ospi_port1_clk_pins_a &ospi_port1_io03_pins_a &ospi_port1_cs0_pins_a>;
--- base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f change-id: 20250806-upstream_fix_dts_omm-c006b69042f1
Best regards,
On 06/08/2025 10:09, Patrice Chotard wrote:
Add memory-region-names property for stm32mp257f-ev1. This allows to identify and check memory-map area's configuration.
No, first entry is already identified.
Cc: stable@vger.kernel.org Fixes: cad2492de91c ("arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board")
No blank lines.
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -197,6 +197,7 @@ &i2c8 { &ommanager { memory-region = <&mm_ospi1>;
- memory-region-names = "mm_ospi1";
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-source... for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.
Best regards, Krzysztof
On 8/6/25 10:23, Krzysztof Kozlowski wrote:
On 06/08/2025 10:09, Patrice Chotard wrote:
Add memory-region-names property for stm32mp257f-ev1. This allows to identify and check memory-map area's configuration.
No, first entry is already identified.
ok
Cc: stable@vger.kernel.org Fixes: cad2492de91c ("arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board")
No blank lines.
ok
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -197,6 +197,7 @@ &i2c8 { &ommanager { memory-region = <&mm_ospi1>;
- memory-region-names = "mm_ospi1";
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see
My bad, i am preparing the v2.
Thanks
Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-source... for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema.
Best regards, Krzysztof
On 06/08/2025 14:36, Patrice CHOTARD wrote:
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -197,6 +197,7 @@ &i2c8 { &ommanager { memory-region = <&mm_ospi1>;
- memory-region-names = "mm_ospi1";
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see
My bad, i am preparing the v2.
Why? I claim this is not needed according to your description. You said it is necessary to identify "memory-map area's configuration." but memory-region already tells that. What exactly is not identified?
Best regards, Krzysztof
On 8/6/25 14:44, Krzysztof Kozlowski wrote:
On 06/08/2025 14:36, Patrice CHOTARD wrote:
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -197,6 +197,7 @@ &i2c8 { &ommanager { memory-region = <&mm_ospi1>;
- memory-region-names = "mm_ospi1";
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see
My bad, i am preparing the v2.
Why? I claim this is not needed according to your description. You said it is necessary to identify "memory-map area's configuration." but memory-region already tells that. What exactly is not identified?
Sorry but memory-region doesn't tell if this area is dedicated to ospi1 or ospi2.
In order to set the AMCR register, which configure the memory-region split between ospi1 and ospi2, we need to identify the ospi instance.
By using memory-region-names, it allows to identify the ospi instance it belongs to.
Thanks Patrice
Best regards, Krzysztof
On Wed, 06 Aug 2025 10:09:35 +0200, Patrice Chotard wrote:
Add memory-region-names property for stm32mp257f-ev1. This allows to identify and check memory-map area's configuration.
Cc: stable@vger.kernel.org Fixes: cad2492de91c ("arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board")
Signed-off-by: Patrice Chotard patrice.chotard@foss.st.com
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 + 1 file changed, 1 insertion(+)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base: Base: using specified base-commit 038d61fd642278bab63ee8ef722c50d10ab01e8f
If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/st/' for 20250806-upstream_fix_dts_omm-v1-1-e68c15ed422d@foss.st.com:
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: ommanager@40500000 (st,stm32mp25-omm): memory-region-names:0: 'mm_ospi1' is not one of ['ospi1', 'ospi2'] from schema $id: http://devicetree.org/schemas/memory-controllers/st,stm32mp25-omm.yaml#
linux-stable-mirror@lists.linaro.org
-
Krzysztof Kozlowski -
Patrice CHOTARD -
Patrice Chotard
-
Rob Herring (Arm)