On Tue, Feb 13, 2018 at 11:26 PM, Pali Rohár pali.rohar@gmail.com wrote:

On Tuesday 13 February 2018 21:43:43 Laszlo Toth wrote:

...

Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally") broke one request, changed it back to the original value.

Tested on a Dell E6540, backlight came back.

Pushed to my review and testing queue, thanks!

...

Fixes: 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally") Signed-off-by: Laszlo Toth laszlth@gmail.com

---

Changes in v2:

• split the fix and the function merge part

Changes in v3:

• added fixes tag

drivers/platform/x86/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 2a68f59..a37cff9 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state) struct calling_interface_buffer buffer; int ret;

• dell_fill_request(&buffer, 0, 0, 0, 0);
  

• dell_fill_request(&buffer, 0x1, 0, 0, 0);
  ret = dell_send_request(&buffer,
                          CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT);
  if (ret)
  

Looks better!

Reviewed-by: Pali Rohár pali.rohar@gmail.com

-- Pali Rohár pali.rohar@gmail.com