On Tue, 2019-01-22 at 15:55 +0000, Sasha Levin wrote:

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag, fixing commit: 94a9174c630c IB/srp: reduce lock coverage of command completion.

The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151, v4.4.171, v3.18.132.

v4.20.3: Build OK! v4.19.16: Build OK! v4.14.94: Build OK! v4.9.151: Build failed! Errors: drivers/infiniband/ulp/srp/ib_srp.c:2657:2: error: implicit declaration of function ‘blk_freeze_queue_start’; did you mean ‘blk_mq_freeze_queue_start’? [-Werror=implicit-function-declaration] drivers/infiniband/ulp/srp/ib_srp.c:2658:14: error: implicit declaration of function ‘blk_mq_freeze_queue_wait_timeout’; did you mean ‘blk_mq_freeze_queue_start’? [-Werror=implicit-function- declaration]

v4.4.171: Build failed! Errors: drivers/infiniband/ulp/srp/ib_srp.c:2612:2: error: implicit declaration of function ‘blk_freeze_queue_start’; did you mean ‘blk_mq_freeze_queue_start’? [-Werror=implicit-function-declaration] drivers/infiniband/ulp/srp/ib_srp.c:2613:14: error: implicit declaration of function ‘blk_mq_freeze_queue_wait_timeout’; did you mean ‘blk_mq_freeze_queue_start’? [-Werror=implicit-function- declaration]

v3.18.132: Failed to apply! Possible dependencies: 205619f2f824 ("IB/srp: Remove stale connection retry mechanism") 34aa654ecb8e ("IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning") 394c595ee8c3 ("IB/srp: Move ib_destroy_cm_id() call into srp_free_ch_ib()") 509c07bc1850 ("IB/srp: Separate target and channel variables") 747fe000ef38 ("IB/srp: Introduce two new srp_target_port member variables") 77f2c1a40e6f ("IB/srp: Use block layer tags") d92c0da71a35 ("IB/srp: Add multichannel support")

How should we proceed with this patch?

Hi Sasha,

Patch 2/2 does not have a "Cc: stable" tag because it definitely should NOT be backported to older kernels. This patch only works for blk-mq which is fine with kernel v5.0. Older kernels however support both the legacy block layer and blk-mq.

Bart.