The SDC controls live in the south tile, not the north one. Correct this so that we program the right registers.
Cc: stable@vger.kernel.org Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver") Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org --- drivers/pinctrl/qcom/pinctrl-qcs404.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qcs404.c b/drivers/pinctrl/qcom/pinctrl-qcs404.c index 7aae52a09ff0..4ffd56ff809e 100644 --- a/drivers/pinctrl/qcom/pinctrl-qcs404.c +++ b/drivers/pinctrl/qcom/pinctrl-qcs404.c @@ -79,7 +79,7 @@ enum { .intr_cfg_reg = 0, \ .intr_status_reg = 0, \ .intr_target_reg = 0, \ - .tile = NORTH, \ + .tile = SOUTH, \ .mux_bit = -1, \ .pull_bit = pull, \ .drv_bit = drv, \
On 31-01-19, 09:29, Bjorn Andersson wrote:
The SDC controls live in the south tile, not the north one. Correct this so that we program the right registers.
Reviewed-by: Vinod Koul vkoul@kernel.org
Cc: stable@vger.kernel.org Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver") Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org
drivers/pinctrl/qcom/pinctrl-qcs404.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qcs404.c b/drivers/pinctrl/qcom/pinctrl-qcs404.c index 7aae52a09ff0..4ffd56ff809e 100644 --- a/drivers/pinctrl/qcom/pinctrl-qcs404.c +++ b/drivers/pinctrl/qcom/pinctrl-qcs404.c @@ -79,7 +79,7 @@ enum { .intr_cfg_reg = 0, \ .intr_status_reg = 0, \ .intr_target_reg = 0, \
.tile = NORTH, \
.mux_bit = -1, \ .pull_bit = pull, \ .drv_bit = drv, \.tile = SOUTH, \
-- 2.18.0
On Thu, Jan 31, 2019 at 6:30 PM Bjorn Andersson bjorn.andersson@linaro.org wrote:
The SDC controls live in the south tile, not the north one. Correct this so that we program the right registers.
Cc: stable@vger.kernel.org Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver") Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org
Patch applied for fixes with Vinod's review tag.
Yours, Linus Walleij
linux-stable-mirror@lists.linaro.org