On Tue, Jul 22, 2025 at 12:05:13PM +0000, Tzung-Bi Shih wrote:

The blocking notifier is registered in cros_ec_register(); however, it isn't unregistered in cros_ec_unregister().

Fix it.

Fixes: 42cd0ab476e2 ("platform/chrome: cros_ec: Query EC protocol version if EC transitions between RO/RW") Cc: stable@vger.kernel.org Signed-off-by: Tzung-Bi Shih tzungbi@kernel.org

Reviewed-by: Benson Leung bleung@chromium.org

---

This is separated from a series (https://lore.kernel.org/chrome-platform/20250721044456.2736300-3-tzungbi@ker...).

While I'm still figuring out/testing the series, it'd be better to send the fix earlier (to catch up the upcoming merge window for example).

drivers/platform/chrome/cros_ec.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index 110771a8645e..fd58781a2fb7 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -318,6 +318,9 @@ EXPORT_SYMBOL(cros_ec_register); */ void cros_ec_unregister(struct cros_ec_device *ec_dev) {

• if (ec_dev->mkbp_event_supported)

• blocking_notifier_chain_unregister(&ec_dev->event_notifier,
  

• 				   &ec_dev->notifier_ready);
  

  platform_device_unregister(ec_dev->pd); platform_device_unregister(ec_dev->ec); mutex_destroy(&ec_dev->lock);

-- 2.50.0.727.gbf7dc18ff4-goog