Hi,

pá 28. 2. 2025 v 13:55 odesílatel Jan Kundrát jan.kundrat@cesnet.cz napsal:

src/timerlat_hist.c: In function ‘timerlat_hist_apply_config’: src/timerlat_hist.c:908:60: error: ‘struct timerlat_hist_params’ has no member named ‘kernel_workload’ 908 | retval = osnoise_set_workload(tool->context, params->kernel_workload); | ^~ make[3]: *** [<builtin>: src/timerlat_hist.o] Error 1

A quick grep shows that that symbol is referenced, but not defined anywhere:

~/work/prog/linux-kernel[cesnet/2025-02-28] $ git grep kernel_workload tools/tracing/rtla/src/timerlat_hist.c: retval = osnoise_set_workload(tool->context, params->kernel_workload); tools/tracing/rtla/src/timerlat_top.c: retval = osnoise_set_workload(top->context, params->kernel_workload);

Maybe some prerequisite patch is missing?

Yes, this is my fault, I missed in the patch review that params->kernel_workload is not present in 6.6-stable, which uses !params->user_hist or !params->user_top instead. There was some discussion last week [1] [2] after which I thought Wang Yugui will send a revert [3] and then I can follow up. It seems like I misread the conversation, I'll send both the revert and the patch myself instead.

[1] https://lore.kernel.org/stable/Z7XtY3GRlRcKCAzs@bender.morinfr.org/ [2] https://lore.kernel.org/stable/20250224182918.C75A.409509F4@e16-tech.com/ [3] https://lore.kernel.org/stable/2025022439-moisten-crave-b6a5@gregkh/

Sorry about the inconvenience.

Tomas