Looks good.

Reviewed-by: Chaitanya Kulkarni chaitanya.kulkarni@wdc.com

On 04/10/2019 01:28 PM, jglisse@redhat.com wrote:

From: Jérôme Glisse jglisse@redhat.com

When bio_add_pc_page() fails in bio_copy_user_iov() we should free the page we just allocated otherwise we are leaking it.

Signed-off-by: Jérôme Glisse jglisse@redhat.com Cc: Jens Axboe axboe@kernel.dk Cc: linux-block@vger.kernel.org Cc: Linus Torvalds torvalds@linux-foundation.org Cc: stable@vger.kernel.org

---

block/bio.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/block/bio.c b/block/bio.c index b64cedc7f87c..716510ecd7ff 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1298,8 +1298,11 @@ struct bio *bio_copy_user_iov(struct request_queue *q, } }

• if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes)
  

• if (bio_add_pc_page(q, bio, page, bytes, offset) < bytes) {
  

• 	if (!map_data)
  

• 		__free_page(page);
  break;
  

• }
  
  

  len -= bytes; offset = 0;