In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_list. Then it tries to rewrite the PTEs via a stale CPU mapping. This causes panic.
Credits-to: Ville Syrjala ville.syrjala@linux.intel.com Shawn Lee shawn.c.lee@intel.com
Cc: stable@vger.kernel.org Fixes: 0dc987b699ce ("drm/i915/display: Add smem fallback allocation for dpt") Signed-off-by: Vidya Srinivas vidya.srinivas@intel.com --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h index 3560a062d287..e6b485fc54d4 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h @@ -284,7 +284,8 @@ bool i915_gem_object_has_iomem(const struct drm_i915_gem_object *obj); static inline bool i915_gem_object_is_shrinkable(const struct drm_i915_gem_object *obj) { - return i915_gem_object_type_has(obj, I915_GEM_OBJECT_IS_SHRINKABLE); + return i915_gem_object_type_has(obj, I915_GEM_OBJECT_IS_SHRINKABLE) && + !obj->is_dpt; }
static inline bool
On Mon, May 20, 2024 at 10:20:05PM +0530, Vidya Srinivas wrote:
In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_list. Then it tries to rewrite the PTEs via a stale CPU mapping. This causes panic.
Credits-to: Ville Syrjala ville.syrjala@linux.intel.com Shawn Lee shawn.c.lee@intel.com
Isn't that what "Co-developed-by:" is for, or "Suggested-by:"?
I haven't seen "Credits-to:" before, where is that documented?
thanks,
greg k-h
-----Original Message----- From: Greg KH gregkh@linuxfoundation.org Sent: Monday, May 20, 2024 11:50 PM To: Srinivas, Vidya vidya.srinivas@intel.com Cc: stable@vger.kernel.org Subject: Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable
On Mon, May 20, 2024 at 10:20:05PM +0530, Vidya Srinivas wrote:
In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_list. Then it tries to rewrite the PTEs via a stale CPU mapping. This causes panic.
Credits-to: Ville Syrjala ville.syrjala@linux.intel.com Shawn Lee shawn.c.lee@intel.com
Isn't that what "Co-developed-by:" is for, or "Suggested-by:"?
I haven't seen "Credits-to:" before, where is that documented?
Hello Greg, thank you. Sorry, I had seen in some of the patches Example https://patchwork.freedesktop.org/patch/404900/ I will change it to Suggested-by.
Regards Vidya
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org