New subject: [tip: sched/core] sched/deadline: Fix replenish_dl_new_period dl_server condition

27 Nov 2024

The condition in replenish_dl_new_period() that checks if a reservation
(dl_server) is deferred and is not handling a starvation case is
obviously wrong.
Fix it.
Cc: stable@vger.kernel.org
Cc: Ingo Molnar mingo@redhat.com
Cc: Peter Zijlstra peterz@infradead.org
Cc: Vincent Guittot vincent.guittot@linaro.org
Cc: Dietmar Eggemann dietmar.eggemann@arm.com
Cc: Steven Rostedt rostedt@goodmis.org
Cc: Ben Segall bsegall@google.com
Cc: Mel Gorman mgorman@suse.de
Cc: Valentin Schneider vschneid@redhat.com
Fixes: a110a81c52a9 ("sched/deadline: Deferrable dl server")
Signed-off-by: Juri Lelli juri.lelli@redhat.com
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index d9d5a702f1a6..206691d35b7d 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -781,7 +781,7 @@ static inline void replenish_dl_new_period(struct sched_dl_entity *dl_se,
     * If it is a deferred reservation, and the server
     * is not handling an starvation case, defer it.
     */
-	if (dl_se->dl_defer & !dl_se->dl_defer_running) {
+	if (dl_se->dl_defer && !dl_se->dl_defer_running) {
    	dl_se->dl_throttled = 1;
    	dl_se->dl_defer_armed = 1;
    }
-- 
2.47.0



    

[PATCH] sched/deadline: Fix replenish_dl_new_period dl_server condition