pstore_compress() and decompress_record() use a mistyped config option name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). As a result compression and decompressionm of pstore records is always disabled.
Use the correct config option name.
Signed-off-by: Jiri Bohac jbohac@suse.cz Fixes: fd49e03280e596e54edb93a91bc96170f8e97e4a ("pstore: Fix linking when crypto API disabled")
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 32f64abc277c..d963ae7902f9 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -269,7 +269,7 @@ static int pstore_compress(const void *in, void *out, { int ret;
- if (!IS_ENABLED(CONFIG_PSTORE_COMPRESSION)) + if (!IS_ENABLED(CONFIG_PSTORE_COMPRESS)) return -EINVAL;
ret = crypto_comp_compress(tfm, in, inlen, out, &outlen); @@ -671,7 +671,7 @@ static void decompress_record(struct pstore_record *record) int unzipped_len; char *unzipped, *workspace;
- if (!IS_ENABLED(CONFIG_PSTORE_COMPRESSION) || !record->compressed) + if (!IS_ENABLED(CONFIG_PSTORE_COMPRESS) || !record->compressed) return;
/* Only PSTORE_TYPE_DMESG support compression. */
On Thu, Feb 18, 2021 at 12:15 PM Jiri Bohac jbohac@suse.cz wrote:
pstore_compress() and decompress_record() use a mistyped config option name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). As a result compression and decompressionm of pstore records is always disabled.
Use the correct config option name.
Signed-off-by: Jiri Bohac jbohac@suse.cz Fixes: fd49e03280e596e54edb93a91bc96170f8e97e4a ("pstore: Fix linking when crypto API disabled")
Acked-by: Matteo Croce mcroce@microsoft.com
On Thu, Feb 18, 2021 at 12:15:47PM +0100, Jiri Bohac wrote:
pstore_compress() and decompress_record() use a mistyped config option name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). As a result compression and decompressionm of pstore records is always disabled.
Use the correct config option name.
Signed-off-by: Jiri Bohac jbohac@suse.cz Fixes: fd49e03280e596e54edb93a91bc96170f8e97e4a ("pstore: Fix linking when crypto API disabled")
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
On Thu, 18 Feb 2021 12:15:47 +0100, Jiri Bohac wrote:
pstore_compress() and decompress_record() use a mistyped config option name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). As a result compression and decompressionm of pstore records is always disabled.
Use the correct config option name.
Eek; thanks for the catch!
Applied to for-next/pstore, thanks!
[1/1] pstore: Fix typo in compression option name https://git.kernel.org/kees/c/19d8e9149c27
linux-stable-mirror@lists.linaro.org