On Wed, 11 Dec 2019 at 00:25, Florian Fainelli f.fainelli@gmail.com wrote:
Hi Jens,
The first 4 patches are fixes and should ideally be queued up/picked up by stable. The last 4 patches add support for BCM7216 which is one of our latest devices supported by this driver.
Patch #2 does a few things, but it was pretty badly broken before and it is hard not to fix all call sites (probe, suspend, resume) in one shot.
Please let me know if you have any comments.
Thanks!
Florian Fainelli (8): ata: libahci_platform: Export again ahci_platform_<en/dis>able_phys() ata: ahci_brcm: Fix AHCI resources management
Following error on stable-rc 4.14 and 4.9 branch for arm build.
drivers/ata/ahci_brcm.c: In function 'brcm_ahci_probe': drivers/ata/ahci_brcm.c:412:28: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? if (!IS_ERR_OR_NULL(priv->rcdev)) ^~~~~ dev CC fs/pnode.o CC block/genhd.o drivers/ata/ahci_brcm.c:413:3: error: implicit declaration of function 'reset_control_assert'; did you mean 'ahci_reset_controller'? [-Werror=implicit-function-declaration] reset_control_assert(priv->rcdev); ^~~~~~~~~~~~~~~~~~~~ ahci_reset_controller drivers/ata/ahci_brcm.c:413:30: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? reset_control_assert(priv->rcdev); ^~~~~ dev cc1: some warnings being treated as errors
Full build log links, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.14/D... https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.9/DI...
On Tue, 7 Jan 2020 at 22:17, Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Wed, 11 Dec 2019 at 00:25, Florian Fainelli f.fainelli@gmail.com wrote:
Hi Jens,
The first 4 patches are fixes and should ideally be queued up/picked up by stable. The last 4 patches add support for BCM7216 which is one of our latest devices supported by this driver.
Patch #2 does a few things, but it was pretty badly broken before and it is hard not to fix all call sites (probe, suspend, resume) in one shot.
Please let me know if you have any comments.
Thanks!
Florian Fainelli (8): ata: libahci_platform: Export again ahci_platform_<en/dis>able_phys() ata: ahci_brcm: Fix AHCI resources management
Following error on stable-rc 4.14 and 4.9 branch for arm build.
Following error on stable-rc 4.19, 4.14 and 4.9 branch for arm build.
drivers/ata/ahci_brcm.c: In function 'brcm_ahci_probe': drivers/ata/ahci_brcm.c:412:28: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? if (!IS_ERR_OR_NULL(priv->rcdev)) ^~~~~ dev CC fs/pnode.o CC block/genhd.o drivers/ata/ahci_brcm.c:413:3: error: implicit declaration of function 'reset_control_assert'; did you mean 'ahci_reset_controller'? [-Werror=implicit-function-declaration] reset_control_assert(priv->rcdev); ^~~~~~~~~~~~~~~~~~~~ ahci_reset_controller drivers/ata/ahci_brcm.c:413:30: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? reset_control_assert(priv->rcdev); ^~~~~ dev cc1: some warnings being treated as errors
Full build log links, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.14/D... https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.9/DI...
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/D...
-- Linaro LKFT https://lkft.linaro.org
On 1/7/20 9:29 AM, Naresh Kamboju wrote:
On Tue, 7 Jan 2020 at 22:17, Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Wed, 11 Dec 2019 at 00:25, Florian Fainelli f.fainelli@gmail.com wrote:
Hi Jens,
The first 4 patches are fixes and should ideally be queued up/picked up by stable. The last 4 patches add support for BCM7216 which is one of our latest devices supported by this driver.
Patch #2 does a few things, but it was pretty badly broken before and it is hard not to fix all call sites (probe, suspend, resume) in one shot.
Please let me know if you have any comments.
Thanks!
Florian Fainelli (8): ata: libahci_platform: Export again ahci_platform_<en/dis>able_phys() ata: ahci_brcm: Fix AHCI resources management
Following error on stable-rc 4.14 and 4.9 branch for arm build.
Following error on stable-rc 4.19, 4.14 and 4.9 branch for arm build.
drivers/ata/ahci_brcm.c: In function 'brcm_ahci_probe': drivers/ata/ahci_brcm.c:412:28: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? if (!IS_ERR_OR_NULL(priv->rcdev)) ^~~~~ dev CC fs/pnode.o CC block/genhd.o drivers/ata/ahci_brcm.c:413:3: error: implicit declaration of function 'reset_control_assert'; did you mean 'ahci_reset_controller'? [-Werror=implicit-function-declaration] reset_control_assert(priv->rcdev); ^~~~~~~~~~~~~~~~~~~~ ahci_reset_controller drivers/ata/ahci_brcm.c:413:30: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? reset_control_assert(priv->rcdev); ^~~~~ dev cc1: some warnings being treated as errors
Full build log links, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.14/D... https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.9/DI...
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/D...
The reset controller support was added in 2b2c47d9e1fe90311b725125d6252a859ee87a79 ("ata: ahci_brcm: Allow optional reset controller to be used") which was include in v4.20 and newer so that explains the build failure.
You may want to cherry pick that change into the respective stable branches and then back port the fixes if that is not too much trouble. If that does not work or is impractical, please let me know and I can provide directed backport changes for 4.9, 4.14 and 4.19.
Thank you
On Tue, Jan 07, 2020 at 09:39:58AM -0800, Florian Fainelli wrote:
On 1/7/20 9:29 AM, Naresh Kamboju wrote:
On Tue, 7 Jan 2020 at 22:17, Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Wed, 11 Dec 2019 at 00:25, Florian Fainelli f.fainelli@gmail.com wrote:
Hi Jens,
The first 4 patches are fixes and should ideally be queued up/picked up by stable. The last 4 patches add support for BCM7216 which is one of our latest devices supported by this driver.
Patch #2 does a few things, but it was pretty badly broken before and it is hard not to fix all call sites (probe, suspend, resume) in one shot.
Please let me know if you have any comments.
Thanks!
Florian Fainelli (8): ata: libahci_platform: Export again ahci_platform_<en/dis>able_phys() ata: ahci_brcm: Fix AHCI resources management
Following error on stable-rc 4.14 and 4.9 branch for arm build.
Following error on stable-rc 4.19, 4.14 and 4.9 branch for arm build.
drivers/ata/ahci_brcm.c: In function 'brcm_ahci_probe': drivers/ata/ahci_brcm.c:412:28: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? if (!IS_ERR_OR_NULL(priv->rcdev)) ^~~~~ dev CC fs/pnode.o CC block/genhd.o drivers/ata/ahci_brcm.c:413:3: error: implicit declaration of function 'reset_control_assert'; did you mean 'ahci_reset_controller'? [-Werror=implicit-function-declaration] reset_control_assert(priv->rcdev); ^~~~~~~~~~~~~~~~~~~~ ahci_reset_controller drivers/ata/ahci_brcm.c:413:30: error: 'struct brcm_ahci_priv' has no member named 'rcdev'; did you mean 'dev'? reset_control_assert(priv->rcdev); ^~~~~ dev cc1: some warnings being treated as errors
Full build log links, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.14/D... https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.9/DI...
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/D...
The reset controller support was added in 2b2c47d9e1fe90311b725125d6252a859ee87a79 ("ata: ahci_brcm: Allow optional reset controller to be used") which was include in v4.20 and newer so that explains the build failure.
You may want to cherry pick that change into the respective stable branches and then back port the fixes if that is not too much trouble. If that does not work or is impractical, please let me know and I can provide directed backport changes for 4.9, 4.14 and 4.19.
No need, I'll just queue up the other needed patch now, thanks.
greg k-h
linux-stable-mirror@lists.linaro.org
-
Florian Fainelli -
Greg Kroah-Hartman -
Naresh Kamboju