From: Zichen Xie zichenxie0106@gmail.com
A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer. NULL Pointer Dereference may be triggerred without addtional check. Add a NULL check for the returned pointer.
Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") Cc: stable@vger.kernel.org Signed-off-by: Zichen Xie zichenxie0106@gmail.com --- v2: Fix "From" tag. v3: Format tags to Fixes/Cc/Signed-off-by. --- sound/soc/qcom/lpass-cpu.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 5a47f661e0c6..242bc16da36d 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1242,6 +1242,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) /* Allocation for i2sctl regmap fields */ drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); + if (!drvdata->i2sctl) + return -ENOMEM;
/* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl,
A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
call?
possibly return NULL pointer. NULL Pointer Dereference may be
Can the term “null pointer dereference” be applied for the final commit message (including the summary phrase)?
triggerred without addtional check.
triggered? additional?
Regards, Markus
On Mon, Oct 07, 2024 at 03:16:27PM +0200, Markus Elfring wrote:
A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could
call?possibly return NULL pointer. NULL Pointer Dereference may be
Can the term “null pointer dereference” be applied for the final commit message (including the summary phrase)?
triggerred without addtional check.
triggered? additional?
Feel free to ignore Markus, he has a long history of sending unhelpful review comments and continues to ignore repeated requests to stop.
…
v2: Fix "From" tag. v3: Format tags to Fixes/Cc/Signed-off-by.
…
* How do you think about to reconsider the version numbers a bit more?
* Would you like to mention the repeated adjustment of the patch subject?
* Can a duplicate marker line be replaced by a blank line?
See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
Is the email address “linux-kernel@vger.kernel.org” still relevant here?
Regards, Markus
On Mon, Oct 07, 2024 at 03:40:21PM +0200, Markus Elfring wrote:
How do you think about to reconsider the version numbers a bit more?
Would you like to mention the repeated adjustment of the patch subject?
Can a duplicate marker line be replaced by a blank line?
Feel free to ignore Markus, he has a long history of sending unhelpful review comments and continues to ignore repeated requests to stop.
On Sun, 06 Oct 2024 15:57:37 -0500, Gax-c wrote:
A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer. NULL Pointer Dereference may be triggerred without addtional check. Add a NULL check for the returned pointer.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() commit: 49da1463c9e3d2082276c3e0e2a8b65a88711cd2
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
linux-stable-mirror@lists.linaro.org
-
Gax-c -
Mark Brown -
Markus Elfring