On 5/1/20 11:43 PM, James Smart wrote:

Implementation of a previous patch added a condition to an if check that always end up with the if test being true. Execution of the else clause was inadvertantly negated. The additional condition check was incorrect and unnecessary after the other modifications had been done in that patch.

Remove the check from the if series.

Fixes: b95b21193c85 ("scsi: lpfc: Fix loss of remote port after devloss due to lack of RPIs") Cc: stable@vger.kernel.org # v5.4+ Signed-off-by: Dick Kennedy dick.kennedy@broadcom.com Signed-off-by: James Smart jsmart2021@gmail.com

---

drivers/scsi/lpfc/lpfc_ct.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index 2aa578d20f8c..7fce73c39c1c 100644 --- a/drivers/scsi/lpfc/lpfc_ct.c +++ b/drivers/scsi/lpfc/lpfc_ct.c @@ -462,7 +462,6 @@ lpfc_prep_node_fc4type(struct lpfc_vport *vport, uint32_t Did, uint8_t fc4_type) struct lpfc_nodelist *ndlp; if ((vport->port_type != LPFC_NPIV_PORT) ||

•    (fc4_type == FC_TYPE_FCP) ||
   !(vport->ct_flags & FC_CT_RFF_ID) || !vport->cfg_restrict_login) {
  

ndlp = lpfc_setup_disc_node(vport, Did);

Reviewed-by: Hannes Reinecke hare@suse.de

Cheers,

Hannes