From: Aili Yao yaoaili@kingsoft.com
From commit 6915564dc5a8 ("ACPI: OSL: Change the type of
acpi_os_map_generic_address() return value"), acpi_os_map_generic_address() will return logical address or NULL for error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return 0, as it's a normal case, but now it will return -ENXIO. so check it out for such case to avoid einj module initialization fail.
Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of acpi_os_map_generic_address() return value") Cc: stable@vger.kernel.org Reviewed-by: James Morse james.morse@arm.com Tested-by: Tony Luck tony.luck@intel.com Signed-off-by: Aili Yao yaoaili@kingsoft.com --- drivers/acpi/apei/apei-base.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c index 552fd9f..3294cc8 100644 --- a/drivers/acpi/apei/apei-base.c +++ b/drivers/acpi/apei/apei-base.c @@ -633,6 +633,10 @@ int apei_map_generic_address(struct acpi_generic_address *reg) if (rc) return rc;
+ /* IO space doesn't need mapping */ + if (reg->space_id == ACPI_ADR_SPACE_SYSTEM_IO) + return 0; + if (!acpi_os_map_generic_address(reg)) return -ENXIO;
On Tue, Nov 10, 2020 at 12:29:42AM -0800, yaoaili126@163.com wrote:
From: Aili Yao yaoaili@kingsoft.com
From commit 6915564dc5a8 ("ACPI: OSL: Change the type of
acpi_os_map_generic_address() return value"), acpi_os_map_generic_address() will return logical address or NULL for error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return 0, as it's a normal case, but now it will return -ENXIO. so check it out for such case to avoid einj module initialization fail.
Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of acpi_os_map_generic_address() return value") Cc: stable@vger.kernel.org Reviewed-by: James Morse james.morse@arm.com Tested-by: Tony Luck tony.luck@intel.com Signed-off-by: Aili Yao yaoaili@kingsoft.com
drivers/acpi/apei/apei-base.c | 4 ++++ 1 file changed, 4 insertions(+)
I'm confused as to what you are asking us to do with this patch? Have you read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly?
thanks,
greg k-h
Sorry for confusing. I am really new to kernel community! I should just add the tag 'Cc: stable@vger.kernel.org' , not really cc to stable@vger.kernel.org sorry for this!
Best Regards!
Aili Yao
-----Original Message----- From: Greg KH [mailto:gregkh@linuxfoundation.org] Sent: Tuesday, November 10, 2020 5:19 PM To: yaoaili126@163.com Cc: yaoaili yaoaili@kingsoft.com; stable@vger.kernel.org Subject: Re: [PATCH] ACPI, APEI, Fix error return value in apei_map_generic_address()
On Tue, Nov 10, 2020 at 12:29:42AM -0800, yaoaili126@163.com wrote:
From: Aili Yao yaoaili@kingsoft.com
From commit 6915564dc5a8 ("ACPI: OSL: Change the type of
acpi_os_map_generic_address() return value"), acpi_os_map_generic_address() will return logical address or NULL for error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return 0, as it's a normal case, but now it will return -ENXIO. so check it out for such case to avoid einj module initialization fail.
Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of acpi_os_map_generic_address() return value") Cc: stable@vger.kernel.org Reviewed-by: James Morse james.morse@arm.com Tested-by: Tony Luck tony.luck@intel.com Signed-off-by: Aili Yao yaoaili@kingsoft.com
drivers/acpi/apei/apei-base.c | 4 ++++ 1 file changed, 4 insertions(+)
I'm confused as to what you are asking us to do with this patch? Have you read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly?
thanks,
greg k-h
On Tue, Nov 10, 2020 at 09:42:21AM +0000, yaoaili [么爱利] wrote:
Sorry for confusing. I am really new to kernel community! I should just add the tag 'Cc: stable@vger.kernel.org' , not really cc to stable@vger.kernel.org sorry for this!
No, that's fine, you just didn't send this to us with any sort of context at all. The patch needs to be accepted by the subsystem maintainer first, right? Please read over Documentation/process/development-process.rst for all of the details on how to do this correctly.
Good luck!
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
yaoaili [么爱利] -
yaoaili126＠163.com