From: Jarkko Sakkinen jarkko.sakkinen@opinsys.com
Remove the export of tpm_crb_ffa_get_interface_version() as it has no callers outside tpm_crb_ffa.
Cc: stable@vger.kernel.org # v6.15+ Fixes: eb93f0734ef1 ("tpm_crb: ffa_tpm: Implement driver compliant to CRB over FF-A") Signed-off-by: Jarkko Sakkinen jarkko.sakkinen@opinsys.com --- drivers/char/tpm/tpm_crb_ffa.c | 3 +-- drivers/char/tpm/tpm_crb_ffa.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c index 462fcf610020..9c6a2988a598 100644 --- a/drivers/char/tpm/tpm_crb_ffa.c +++ b/drivers/char/tpm/tpm_crb_ffa.c @@ -247,7 +247,7 @@ static int __tpm_crb_ffa_send_recieve(unsigned long func_id, * * Return: 0 on success, negative error code on failure. */ -int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor) +static int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor) { int rc;
@@ -275,7 +275,6 @@ int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor)
return rc; } -EXPORT_SYMBOL_GPL(tpm_crb_ffa_get_interface_version);
/** * tpm_crb_ffa_start() - signals the TPM that a field has changed in the CRB diff --git a/drivers/char/tpm/tpm_crb_ffa.h b/drivers/char/tpm/tpm_crb_ffa.h index 645c41ede10e..d7e1344ea003 100644 --- a/drivers/char/tpm/tpm_crb_ffa.h +++ b/drivers/char/tpm/tpm_crb_ffa.h @@ -11,11 +11,9 @@
#if IS_REACHABLE(CONFIG_TCG_ARM_CRB_FFA) int tpm_crb_ffa_init(void); -int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor); int tpm_crb_ffa_start(int request_type, int locality); #else static inline int tpm_crb_ffa_init(void) { return 0; } -static inline int tpm_crb_ffa_get_interface_version(u16 *major, u16 *minor) { return 0; } static inline int tpm_crb_ffa_start(int request_type, int locality) { return 0; } #endif
On Thu, Jun 26, 2025 at 01:54:23PM +0300, Jarkko Sakkinen wrote:
From: Jarkko Sakkinen jarkko.sakkinen@opinsys.com
Remove the export of tpm_crb_ffa_get_interface_version() as it has no callers outside tpm_crb_ffa.
Cc: stable@vger.kernel.org # v6.15+
Why is this marked for stable trees as a fix? Seems to just be a normal cleanup patch to me, what am I missing?
thanks,
greg k-h
On Thu, Jun 26, 2025 at 11:58:26AM +0100, Greg KH wrote:
On Thu, Jun 26, 2025 at 01:54:23PM +0300, Jarkko Sakkinen wrote:
From: Jarkko Sakkinen jarkko.sakkinen@opinsys.com
Remove the export of tpm_crb_ffa_get_interface_version() as it has no callers outside tpm_crb_ffa.
Cc: stable@vger.kernel.org # v6.15+
Why is this marked for stable trees as a fix? Seems to just be a normal cleanup patch to me, what am I missing?
unintentional, i added it as a reflex (was going to add the fixes tag for bookmark/reference)
thanks,
greg k-h
BR, Jarkko
[...]
Look good to me. Feel free to add:
Reviewed-by: Yeoreum Yun yeoreum.yun@arm.com
Thanks!
-- Sincerely, Yeoreum Yun
On Thu, Jun 26, 2025 at 12:05:21PM +0100, Yeoreum Yun wrote:
[...]
Look good to me. Feel free to add:
Reviewed-by: Yeoreum Yun yeoreum.yun@arm.com
Thanks!
-- Sincerely, Yeoreum Yun
Thanks!
BR, Jarkko
linux-stable-mirror@lists.linaro.org