The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA, which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the correct value of 11 so that access to necessary device registers is properly requested in the ws16c48_probe() callback by the devm_request_region() function call.
Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures") Cc: stable@vger.kernel.org Cc: Paul Demetrotion pdemetrotion@winsystems.com Signed-off-by: William Breathitt Gray william.gray@linaro.org --- drivers/gpio/gpio-ws16c48.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c index 701847508e94..6289b0510cf2 100644 --- a/drivers/gpio/gpio-ws16c48.c +++ b/drivers/gpio/gpio-ws16c48.c @@ -17,7 +17,7 @@ #include <linux/regmap.h> #include <linux/types.h>
-#define WS16C48_EXTENT 10 +#define WS16C48_EXTENT 11 #define MAX_NUM_WS16C48 max_num_isa_dev(WS16C48_EXTENT)
static unsigned int base[MAX_NUM_WS16C48];
On Thu, Aug 10, 2023 at 06:00:44PM -0400, William Breathitt Gray wrote:
The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA, which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the correct value of 11 so that access to necessary device registers is properly requested in the ws16c48_probe() callback by the devm_request_region() function call.
Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
Fixes should go first in the series, but I see no conflict here, I hope Bart can manage this when applying.
Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
On Fri, Aug 11, 2023 at 12:19:54PM +0300, Andy Shevchenko wrote:
On Thu, Aug 10, 2023 at 06:00:44PM -0400, William Breathitt Gray wrote:
The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA, which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the correct value of 11 so that access to necessary device registers is properly requested in the ws16c48_probe() callback by the devm_request_region() function call.
Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures")
Fixes should go first in the series, but I see no conflict here, I hope Bart can manage this when applying.
Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
-- With Best Regards, Andy Shevchenko
Bart, if you encounter any issues reordering this patch first before the others, just let me know and I'll send a rebased version with the appropriate context adjustments.
Thanks,
William Breathitt Gray
linux-stable-mirror@lists.linaro.org