From: Lu Baolu baolu.lu@linux.intel.com
ANBZ: #1105
commit 474dd1c6506411752a9b2f2233eec11f1733a099 upstream.
The commit 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") fixes an issue of "sub-device is removed where the context entry is cleared for all aliases". But this commit didn't consider the PASID entry and PASID table in VT-d scalable mode. This fix increases the coverage of scalable mode.
Suggested-by: Sanjay Kumar sanjay.k.kumar@intel.com Fixes: 8038bdb855331 ("iommu/vt-d: Only clear real DMA device's context entries") Fixes: 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") Cc: stable@vger.kernel.org # v5.6+ Cc: Jon Derrick jonathan.derrick@intel.com Signed-off-by: Lu Baolu baolu.lu@linux.intel.com Signed-off-by: Kun(llfl) llfl@linux.alibaba.com --- drivers/iommu/intel/iommu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 1a0027da6dad..34e498619210 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -5126,14 +5126,13 @@ static void __dmar_remove_one_dev_info(struct device_domain_info *info) iommu = info->iommu; domain = info->domain;
- if (info->dev) { + if (info->dev && !dev_is_real_dma_subdevice(info->dev)) { if (dev_is_pci(info->dev) && sm_supported(iommu)) intel_pasid_tear_down_entry(iommu, info->dev, PASID_RID2PASID, false);
iommu_disable_dev_iotlb(info); - if (!dev_is_real_dma_subdevice(info->dev)) - domain_context_clear(info); + domain_context_clear(info); intel_pasid_free_table(info->dev); }
On Fri, May 06, 2022 at 08:00:44PM +0800, Kun(llfl) wrote:
From: Lu Baolu baolu.lu@linux.intel.com
ANBZ: #1105
commit 474dd1c6506411752a9b2f2233eec11f1733a099 upstream.
The commit 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") fixes an issue of "sub-device is removed where the context entry is cleared for all aliases". But this commit didn't consider the PASID entry and PASID table in VT-d scalable mode. This fix increases the coverage of scalable mode.
Suggested-by: Sanjay Kumar sanjay.k.kumar@intel.com Fixes: 8038bdb855331 ("iommu/vt-d: Only clear real DMA device's context entries") Fixes: 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") Cc: stable@vger.kernel.org # v5.6+
Same here, what kernels is this to be applied to, and what is the "ANBZ" tag?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org