On 2025-05-14 16:04, Wentao Liang wrote:

The function avs_card_suspend_pre() in nau8825 calls the function snd_soc_card_get_codec_dai(), but does not check its return value which is a null pointer if the function fails. This can result in a null pointer dereference. A proper implementation can be found in acp5x_nau8821_hw_params() and card_suspend_pre().

Add a null pointer check for snd_soc_card_get_codec_dai() to avoid null pointer dereference when the function fails.

Fixes: 9febcd7a0180 ("ASoC: Intel: avs: nau8825: Refactor jack handling") Cc: stable@vger.kernel.org # v6.2 Signed-off-by: Wentao Liang vulab@iscas.ac.cn

---

sound/soc/intel/avs/boards/nau8825.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/sound/soc/intel/avs/boards/nau8825.c b/sound/soc/intel/avs/boards/nau8825.c index bf902540744c..5baeb95cd5a6 100644 --- a/sound/soc/intel/avs/boards/nau8825.c +++ b/sound/soc/intel/avs/boards/nau8825.c @@ -220,6 +220,11 @@ static int avs_card_suspend_pre(struct snd_soc_card *card) { struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, SKL_NUVOTON_CODEC_DAI);

• if (!codec_dai) {

• dev_err(card->dev, "Codec dai not found\n");
  

• return -EINVAL;
  

• }
• return snd_soc_component_set_jack(codec_dai->component, NULL, NULL); }

Same as in other case, where Cezary commented - this is not needed, once card is loaded codec should exist.