-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
for you to fetch changes up to 23429535347ee9389c70fc2be5f6fcdb9e2d5bc4:
ARM: 8753/1: decompressor: add a missing parameter to the addruart macro (2018-06-02 16:53:18 -0400)
- ---------------------------------------------------------------- for-greg-3.18-04062018
- ---------------------------------------------------------------- Amir Goldstein (1): fsnotify: fix ignore mask logic in send_to_group()
Arnd Bergmann (2): hexagon: add memset_io() helper hexagon: export csum_partial_copy_nocheck
Baolin Wang (1): parisc: time: Convert read_persistent_clock() to read_persistent_clock64()
Ben Hutchings (1): drm/msm: Fix possible null dereference on failure of get_pages()
Chengguang Xu (1): isofs: fix potential memory leak in mount option parsing
Chris Leech (1): scsi: iscsi: respond to netlink with unicast when appropriate
Colin Ian King (1): scsi: isci: Fix infinite loop in while loop
Dag Moxnes (1): rds: ib: Fix missing call to rds_ib_dev_put in rds_ib_setup_qp
Daniel Glöckner (1): usb: musb: fix remote wakeup racing with suspend
Greg Thelen (3): ib_srpt: depend on INFINIBAND_ADDR_TRANS ib_srp: depend on INFINIBAND_ADDR_TRANS IB: make INFINIBAND_ADDR_TRANS configurable
Helge Deller (2): parisc: drivers.c: Fix section mismatches parisc: Move setup_profiling_timer() out of init section
Håkon Bugge (1): IB/core: Make ib_mad_client_id atomic
Ilan Peer (1): mac80211: Adjust SAE authentication timeout
Jakob Unterwurzacher (1): can: dev: increase bus-off message severity
Jim Gill (1): scsi: vmw-pvscsi: return DID_BUS_BUSY for adapter-initated aborts
Jingju Hou (1): net: phy: marvell: clear wol event before setting it
John Fastabend (1): bpf: fix uninitialized variable in bpf tools
Kevin Easton (1): af_key: Always verify length of provided sadb_key
Mark Rutland (2): arm64: ptrace: remove addr_limit manipulation arm64: fix possible spectre-v1 in ptrace_hbp_get_event()
Martin Schwidefsky (1): s390/smsgiucv: disable SMSG on module unload
Masami Hiramatsu (1): selftests: ftrace: Add a testcase for multiple actions on trigger
Mathieu Malaterre (2): driver core: add __printf verification to __ata_ehi_pushv_desc agp: uninorth: make two functions static
Naveen N. Rao (1): powerpc/trace/syscalls: Update syscall name matching logic
Peter Rosin (3): i2c: pmcmsp: return message count on master_xfer success i2c: pmcmsp: fix error return from master_xfer i2c: viperboard: return message count on master_xfer success
Peter Zijlstra (1): kthread, sched/wait: Fix kthread_parkme() wait-loop
Russell King (1): ARM: keystone: fix platform_domain_notifier array overrun
Sekhar Nori (2): ARM: davinci: board-dm355-evm: fix broken networking ARM: davinci: board-dm646x-evm: set VPIF capture card name
Sinan Kaya (1): MIPS: io: Add barrier after register read in readX()
Tomi Valkeinen (1): drm/omap: fix possible NULL ref issue in tiler_reserve_2d
jacek.tomaka@poczta.fm (1): x86/cpu/intel: Add missing TLB cpuid values
Łukasz Stelmach (1): ARM: 8753/1: decompressor: add a missing parameter to the addruart macro
arch/arm/boot/compressed/head.S | 16 ++++---- arch/arm/mach-davinci/board-dm355-evm.c | 6 +++ arch/arm/mach-davinci/board-dm646x-evm.c | 3 +- arch/arm/mach-keystone/pm_domain.c | 1 + arch/arm64/kernel/ptrace.c | 20 +++++----- arch/hexagon/include/asm/io.h | 6 +++ arch/hexagon/lib/checksum.c | 1 + arch/mips/include/asm/io.h | 2 + arch/parisc/kernel/drivers.c | 7 ++-- arch/parisc/kernel/smp.c | 3 +- arch/parisc/kernel/time.c | 2 +- arch/powerpc/include/asm/ftrace.h | 10 ++--- arch/x86/kernel/cpu/intel.c | 3 ++ drivers/ata/libata-eh.c | 4 +- drivers/char/agp/uninorth-agp.c | 4 +- drivers/gpu/drm/msm/msm_gem.c | 20 +++++----- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 ++- drivers/i2c/busses/i2c-pmcmsp.c | 4 +- drivers/i2c/busses/i2c-viperboard.c | 2 +- drivers/infiniband/Kconfig | 5 ++- drivers/infiniband/core/mad.c | 4 +- drivers/infiniband/ulp/srp/Kconfig | 2 +- drivers/infiniband/ulp/srpt/Kconfig | 2 +- drivers/net/can/dev.c | 2 +- drivers/net/phy/marvell.c | 9 +++++ drivers/s390/net/smsgiucv.c | 2 +- drivers/scsi/isci/port_config.c | 3 +- drivers/scsi/scsi_transport_iscsi.c | 29 ++++++++------ drivers/scsi/vmw_pvscsi.c | 2 +- drivers/usb/musb/musb_host.c | 5 ++- drivers/usb/musb/musb_host.h | 7 +++- drivers/usb/musb/musb_virthub.c | 25 +++++++----- fs/isofs/inode.c | 3 ++ fs/notify/fsnotify.c | 25 ++++++------ kernel/kthread.c | 7 ++-- net/key/af_key.c | 45 +++++++++++++++++----- net/mac80211/mlme.c | 25 ++++++++---- net/rds/ib_cm.c | 3 +- tools/net/bpf_dbg.c | 7 +++- .../inter-event/trigger-multi-actions-accept.tc | 44 +++++++++++++++++++++ 40 files changed, 256 insertions(+), 120 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-multi-actions-accept.tc
On 5 June 2018 9:30:44 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No such file or directory #include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257: arch/arm64/kernel/ptrace.o] Error 1 make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947: arch/arm64/kernel] Error 2 make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit 19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No such file or directory #include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257: arch/arm64/kernel/ptrace.o] Error 1 make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947: arch/arm64/kernel] Error 2 make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit 19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
Greg, could you please hold off on these pull requests until I figure it out? Sorry.
On 5 June 2018 1:00:54 PM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No
such file or directory
#include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257:
arch/arm64/kernel/ptrace.o] Error 1
make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947:
arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit
19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
On the last PR (or the one before?) there was also a compile time warning introduced on all architectures using the net subsystem so clearly something's very wrong with the buildbot and fixing the issue should probably be prioritised to avoid further incidents like this.
On Tue, Jun 05, 2018 at 02:39:33PM +0530, Harsh Shandilya wrote:
On 5 June 2018 1:00:54 PM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No
such file or directory
#include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257:
arch/arm64/kernel/ptrace.o] Error 1
make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947:
arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit
19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
On the last PR (or the one before?) there was also a compile time warning introduced on all architectures using the net subsystem so clearly something's very wrong with the buildbot and fixing the issue should probably be prioritised to avoid further incidents like this.
Okay, two lessons learned on my end:
1. Pushing a branch/tag to git.kernel.org does not make it immediately available for pulling on a different host, so if I have a script that does something like this:
git push -f sasha-stable my-stable-branch ssh buildbox git fetch sasha-stable
then an updated "my-stable-branch" not appear immediately. There's some sort of a delay on git.kernel.org.
2. 'git fetch' might not necessarily update tags (I don't quite understand the logic), I should have used 'git fetch --tags' instead.
On 6 June 2018 12:16:24 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 02:39:33PM +0530, Harsh Shandilya wrote:
On 5 June 2018 1:00:54 PM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No
such file or directory
#include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257:
arch/arm64/kernel/ptrace.o] Error 1
make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947:
arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit
19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
On the last PR (or the one before?) there was also a compile time
warning introduced on all architectures using the net subsystem so clearly something's very wrong with the buildbot and fixing the issue should probably be prioritised to avoid further incidents like this.
Okay, two lessons learned on my end:
- Pushing a branch/tag to git.kernel.org does not make it immediately
available for pulling on a different host, so if I have a script that does something like this:
git push -f sasha-stable my-stable-branch ssh buildbox git fetch sasha-stable
then an updated "my-stable-branch" not appear immediately. There's some sort of a delay on git.kernel.org.
I can confirm this in the same scenario, I saw the pull request email and went to run a merge test and kernel.org kept saying there were no updates for a good minute before the tags showed up.
- 'git fetch' might not necessarily update tags (I don't quite
understand the logic), I should have used 'git fetch --tags' instead.
'git fetch' never updates tags as per design AFAIK, but 'git remote update' does.
Let's hope the lessons learnt here actually prove useful.
On Wed, Jun 06, 2018 at 12:24:32AM +0530, Harsh Shandilya wrote:
On 6 June 2018 12:16:24 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 02:39:33PM +0530, Harsh Shandilya wrote:
On 5 June 2018 1:00:54 PM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 3.18 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
=====
The following changes since commit 8eb1ef076bab4bd4975922a06bdffa3d40c4197c:
Linux 3.18.111 (2018-05-30 07:47:45 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h: No
such file or directory
#include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257:
arch/arm64/kernel/ptrace.o] Error 1
make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947:
arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit
19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
On the last PR (or the one before?) there was also a compile time
warning introduced on all architectures using the net subsystem so clearly something's very wrong with the buildbot and fixing the issue should probably be prioritised to avoid further incidents like this.
Okay, two lessons learned on my end:
- Pushing a branch/tag to git.kernel.org does not make it immediately
available for pulling on a different host, so if I have a script that does something like this:
git push -f sasha-stable my-stable-branch ssh buildbox git fetch sasha-stable
then an updated "my-stable-branch" not appear immediately. There's some sort of a delay on git.kernel.org.
I can confirm this in the same scenario, I saw the pull request email and went to run a merge test and kernel.org kept saying there were no updates for a good minute before the tags showed up.
What happened in my case is that it proceeded with building the previous version, which had no errors :)
- 'git fetch' might not necessarily update tags (I don't quite
understand the logic), I should have used 'git fetch --tags' instead.
'git fetch' never updates tags as per design AFAIK, but 'git remote update' does.
But it did for me, which is why I was puzzled. Doing a simple git fetch earlier I got:
$ git fetch --all Fetching origin Fetching stable Fetching sstable remote: Counting objects: 1898, done. remote: Compressing objects: 100% (735/735), done. remote: Total 1898 (delta 1581), reused 1472 (delta 1160) Receiving objects: 100% (1898/1898), 331.02 KiB | 10.68 MiB/s, done. Resolving deltas: 100% (1581/1581), completed with 521 local objects.
From git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
* [new tag] for-greg-4.14-05062018 -> for-greg-4.14-05062018 * [new tag] for-greg-4.16-05062018 -> for-greg-4.16-05062018 * [new tag] for-greg-4.4-05062018 -> for-greg-4.4-05062018 * [new tag] for-greg-4.9-05062018 -> for-greg-4.9-05062018
But then when I added "--tags" it fetch a lot more tags, and actually updated a tag too:
$ git fetch --tags --all Fetching origin Fetching stable Fetching sstable remote: Counting objects: 38176, done. remote: Compressing objects: 100% (9185/9185), done. remote: Total 38176 (delta 33775), reused 32396 (delta 28948) Receiving objects: 100% (38176/38176), 7.64 MiB | 22.04 MiB/s, done. Resolving deltas: 100% (33775/33775), completed with 3782 local objects.
From git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
* [new tag] for-greg-3.18-02122017 -> for-greg-3.18-02122017 * [new tag] for-greg-3.18-04022018 -> for-greg-3.18-04022018 * [new tag] for-greg-3.18-04052018 -> for-greg-3.18-04052018 * [new tag] for-greg-3.18-05062018 -> for-greg-3.18-05062018 * [new tag] for-greg-3.18-11122017 -> for-greg-3.18-11122017 * [new tag] for-greg-3.18-14122017 -> for-greg-3.18-14122017 * [new tag] for-greg-3.18-15042018 -> for-greg-3.18-15042018 * [new tag] for-greg-3.18-20122017 -> for-greg-3.18-20122017 * [new tag] for-greg-3.18-23022018 -> for-greg-3.18-23022018 * [new tag] for-greg-3.18-26042018 -> for-greg-3.18-26042018 * [new tag] for-greg-3.18-28012018 -> for-greg-3.18-28012018 * [new tag] for-greg-4.14-02122017 -> for-greg-4.14-02122017 * [new tag] for-greg-4.14-04022018 -> for-greg-4.14-04022018 * [new tag] for-greg-4.14-04052018 -> for-greg-4.14-04052018 t [tag update] for-greg-4.14-04062018 -> for-greg-4.14-04062018 [...]
So I *thought* that git fetch was working right, but really it wasn't the case.
On 6 June 2018 12:29:58 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Wed, Jun 06, 2018 at 12:24:32AM +0530, Harsh Shandilya wrote:
On 6 June 2018 12:16:24 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 02:39:33PM +0530, Harsh Shandilya wrote:
On 5 June 2018 1:00:54 PM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
On Tue, Jun 05, 2018 at 12:12:10PM +0530, Harsh Shandilya wrote:
On 5 June 2018 9:30:44 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
>-----BEGIN PGP SIGNED MESSAGE----- >Hash: SHA512 > >Hi Greg, > >Pleae pull commits for Linux 3.18 . > >I've sent a review request for all commits over a week ago and
all
>comments were addressed. > > >Thanks, >Sasha > >===== > > >The following changes since commit >8eb1ef076bab4bd4975922a06bdffa3d40c4197c: > > Linux 3.18.111 (2018-05-30 07:47:45 +0200) > >are available in the Git repository at: > >git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git >tags/for-greg-3.18-04062018
Vanilla arm64 build fails with
../arch/arm64/kernel/ptrace.c:27:10: fatal error: linux/nospec.h:
No
such file or directory
#include <linux/nospec.h> ^~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [../scripts/Makefile.build:257:
arch/arm64/kernel/ptrace.o] Error 1
make[1]: *** [/home/msfjarvis/oneplus3/Makefile:947:
arch/arm64/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
Caused by the backport of Upstream commit
19791a7ca674fb3009bb068260e852a2f05b605c ("arm64: fix possible spectre-v1 in ptrace_hbp_get_event()").
Thanks Harsh.
I don't understand why my built bot skipped this.
On the last PR (or the one before?) there was also a compile time
warning introduced on all architectures using the net subsystem so clearly something's very wrong with the buildbot and fixing the issue should probably be prioritised to avoid further incidents like this.
Okay, two lessons learned on my end:
- Pushing a branch/tag to git.kernel.org does not make it
immediately
available for pulling on a different host, so if I have a script that does something like this:
git push -f sasha-stable my-stable-branch ssh buildbox git fetch sasha-stable
then an updated "my-stable-branch" not appear immediately. There's
some
sort of a delay on git.kernel.org.
I can confirm this in the same scenario, I saw the pull request email
and went to run a merge test and kernel.org kept saying there were no updates for a good minute before the tags showed up.
What happened in my case is that it proceeded with building the previous version, which had no errors :)
- 'git fetch' might not necessarily update tags (I don't quite
understand the logic), I should have used 'git fetch --tags' instead.
'git fetch' never updates tags as per design AFAIK, but 'git remote
update' does.
But it did for me, which is why I was puzzled. Doing a simple git fetch earlier I got:
$ git fetch --all Fetching origin Fetching stable Fetching sstable remote: Counting objects: 1898, done. remote: Compressing objects: 100% (735/735), done. remote: Total 1898 (delta 1581), reused 1472 (delta 1160) Receiving objects: 100% (1898/1898), 331.02 KiB | 10.68 MiB/s, done. Resolving deltas: 100% (1581/1581), completed with 521 local objects. From git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
- [new tag] for-greg-4.14-05062018 ->
for-greg-4.14-05062018
- [new tag] for-greg-4.16-05062018 ->
for-greg-4.16-05062018
- [new tag] for-greg-4.4-05062018 ->
for-greg-4.4-05062018
- [new tag] for-greg-4.9-05062018 ->
for-greg-4.9-05062018
But then when I added "--tags" it fetch a lot more tags, and actually updated a tag too:
If you pay attention, the only tags fetched above were ones attached to a branch. Adding --tags pulls every tag despite the git hash for it not existing on any branch.
$ git fetch --tags --all Fetching origin Fetching stable Fetching sstable remote: Counting objects: 38176, done. remote: Compressing objects: 100% (9185/9185), done. remote: Total 38176 (delta 33775), reused 32396 (delta 28948) Receiving objects: 100% (38176/38176), 7.64 MiB | 22.04 MiB/s, done. Resolving deltas: 100% (33775/33775), completed with 3782 local objects. From git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
- [new tag] for-greg-3.18-02122017 ->
for-greg-3.18-02122017
- [new tag] for-greg-3.18-04022018 ->
for-greg-3.18-04022018
- [new tag] for-greg-3.18-04052018 ->
for-greg-3.18-04052018
- [new tag] for-greg-3.18-05062018 ->
for-greg-3.18-05062018
- [new tag] for-greg-3.18-11122017 ->
for-greg-3.18-11122017
- [new tag] for-greg-3.18-14122017 ->
for-greg-3.18-14122017
- [new tag] for-greg-3.18-15042018 ->
for-greg-3.18-15042018
- [new tag] for-greg-3.18-20122017 ->
for-greg-3.18-20122017
- [new tag] for-greg-3.18-23022018 ->
for-greg-3.18-23022018
- [new tag] for-greg-3.18-26042018 ->
for-greg-3.18-26042018
- [new tag] for-greg-3.18-28012018 ->
for-greg-3.18-28012018
- [new tag] for-greg-4.14-02122017 ->
for-greg-4.14-02122017
- [new tag] for-greg-4.14-04022018 ->
for-greg-4.14-04022018
- [new tag] for-greg-4.14-04052018 ->
for-greg-4.14-04052018 t [tag update] for-greg-4.14-04062018 -> for-greg-4.14-04062018 [...]
So I *thought* that git fetch was working right, but really it wasn't the case.
It _was_ working fine, but the design is too weird to risk things like this by not being explicit with your options.
On Wed, Jun 06, 2018 at 01:19:50AM +0530, Harsh Shandilya wrote:
On 6 June 2018 12:29:58 AM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
From git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
- [new tag] for-greg-3.18-02122017 ->
for-greg-3.18-02122017
- [new tag] for-greg-3.18-04022018 ->
for-greg-3.18-04022018
- [new tag] for-greg-3.18-04052018 ->
for-greg-3.18-04052018
- [new tag] for-greg-3.18-05062018 ->
for-greg-3.18-05062018
- [new tag] for-greg-3.18-11122017 ->
for-greg-3.18-11122017
- [new tag] for-greg-3.18-14122017 ->
for-greg-3.18-14122017
- [new tag] for-greg-3.18-15042018 ->
for-greg-3.18-15042018
- [new tag] for-greg-3.18-20122017 ->
for-greg-3.18-20122017
- [new tag] for-greg-3.18-23022018 ->
for-greg-3.18-23022018
- [new tag] for-greg-3.18-26042018 ->
for-greg-3.18-26042018
- [new tag] for-greg-3.18-28012018 ->
for-greg-3.18-28012018
- [new tag] for-greg-4.14-02122017 ->
for-greg-4.14-02122017
- [new tag] for-greg-4.14-04022018 ->
for-greg-4.14-04022018
- [new tag] for-greg-4.14-04052018 ->
for-greg-4.14-04052018 t [tag update] for-greg-4.14-04062018 -> for-greg-4.14-04062018 [...]
So I *thought* that git fetch was working right, but really it wasn't the case.
It _was_ working fine, but the design is too weird to risk things like this by not being explicit with your options.
So the tags that get pulled depend on whether you have the corresponding branch (object) locally? WTF
Anyways, could you please test out for-greg-3.18-05062018 before I send it out? Now with less build bugs :)
On 6 June 2018 7:50:04 PM IST, Sasha Levin Alexander.Levin@microsoft.com wrote:
On Wed, Jun 06, 2018 at 01:19:50AM +0530, Harsh Shandilya wrote:
On 6 June 2018 12:29:58 AM IST, Sasha Levin
Alexander.Levin@microsoft.com wrote:
From
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable
- [new tag] for-greg-3.18-02122017 ->
for-greg-3.18-02122017
- [new tag] for-greg-3.18-04022018 ->
for-greg-3.18-04022018
- [new tag] for-greg-3.18-04052018 ->
for-greg-3.18-04052018
- [new tag] for-greg-3.18-05062018 ->
for-greg-3.18-05062018
- [new tag] for-greg-3.18-11122017 ->
for-greg-3.18-11122017
- [new tag] for-greg-3.18-14122017 ->
for-greg-3.18-14122017
- [new tag] for-greg-3.18-15042018 ->
for-greg-3.18-15042018
- [new tag] for-greg-3.18-20122017 ->
for-greg-3.18-20122017
- [new tag] for-greg-3.18-23022018 ->
for-greg-3.18-23022018
- [new tag] for-greg-3.18-26042018 ->
for-greg-3.18-26042018
- [new tag] for-greg-3.18-28012018 ->
for-greg-3.18-28012018
- [new tag] for-greg-4.14-02122017 ->
for-greg-4.14-02122017
- [new tag] for-greg-4.14-04022018 ->
for-greg-4.14-04022018
- [new tag] for-greg-4.14-04052018 ->
for-greg-4.14-04052018 t [tag update] for-greg-4.14-04062018 -> for-greg-4.14-04062018 [...]
So I *thought* that git fetch was working right, but really it wasn't the case.
It _was_ working fine, but the design is too weird to risk things like
this by not being explicit with your options.
So the tags that get pulled depend on whether you have the corresponding branch (object) locally? WTF
Anyways, could you please test out for-greg-3.18-05062018 before I send it out? Now with less build bugs :)
Sorry for the delay, got busy setting up my PC. OnePlus 3T builds fine with the merge of for-greg-3.18-05062018, no obvious regressions noticed.
linux-stable-mirror@lists.linaro.org
-
Harsh Shandilya -
Sasha Levin