Hello there Eric,

Fix a silly bug where an array was used outside of its scope.

I am surprised your C compiler doesn't find this bug. gcc 14.2 onwards should be able to, but clang not.

I will make an enhancement request in clang.

Regards

David Binderman

Fixes: 2051da858534 ("arm64/crc-t10dif: expose CRC-T10DIF function through lib") Cc: stable@vger.kernel.org Reported-by: David Binderman dcb314@hotmail.com Closes: https://lore.kernel.org/r/AS8PR02MB102170568EAE7FFDF93C8D1ED9CA62@AS8PR02MB1... Signed-off-by: Eric Biggers ebiggers@google.com ---  arch/arm64/lib/crc-t10dif-glue.c | 4 +---  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/lib/crc-t10dif-glue.c b/arch/arm64/lib/crc-t10dif-glue.c index a007d0c5f3fed..bacd18f231688 100644 --- a/arch/arm64/lib/crc-t10dif-glue.c +++ b/arch/arm64/lib/crc-t10dif-glue.c @@ -43,13 +43,11 @@ u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length)                            kernel_neon_begin();                          crc_t10dif_pmull_p8(crc, data, length, buf);                          kernel_neon_end();   -                       crc = 0; -                       data = buf; -                       length = sizeof(buf); +                       return crc_t10dif_generic(0, buf, sizeof(buf));                  }          }          return crc_t10dif_generic(crc, data, length);  }  EXPORT_SYMBOL(crc_t10dif_arch);

base-commit: 1e26c5e28ca5821a824e90dd359556f5e9e7b89f -- 2.49.0