On Thu, Sep 07, 2023 at 02:17:16PM +0000, Maximilian Heyne wrote:
With the recent removal of vm_dev from devres its memory is only freed via the callback virtio_mmio_release_dev. However, this only takes effect after device_add is called by register_virtio_device. Until then it's an unmanaged resource and must be explicitly freed on error exit.
This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
Cc: stable@vger.kernel.org Fixes: 55c91fedd03d ("virtio-mmio: don't break lifecycle of vm_dev") Signed-off-by: Maximilian Heyne mheyne@amazon.de
Reviewed-by: Catalin Marinas catalin.marinas@arm.com Tested-by: Catalin Marinas catalin.marinas@arm.com
Thanks.
On Thu, Sep 07, 2023 at 05:28:25PM +0100, Catalin Marinas wrote:
On Thu, Sep 07, 2023 at 02:17:16PM +0000, Maximilian Heyne wrote:
With the recent removal of vm_dev from devres its memory is only freed via the callback virtio_mmio_release_dev. However, this only takes effect after device_add is called by register_virtio_device. Until then it's an unmanaged resource and must be explicitly freed on error exit.
This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
Cc: stable@vger.kernel.org Fixes: 55c91fedd03d ("virtio-mmio: don't break lifecycle of vm_dev") Signed-off-by: Maximilian Heyne mheyne@amazon.de
Reviewed-by: Catalin Marinas catalin.marinas@arm.com Tested-by: Catalin Marinas catalin.marinas@arm.com
Thanks.
-- Catalin
Who would apply this patch? Something seems to have choked my patch so it didn't reach lore.kernel.org (message couldn't be delivered due to timeout). Should I try to send it again?
Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
On Fri, Sep 08, 2023 at 11:38:40AM +0000, Maximilian Heyne wrote:
On Thu, Sep 07, 2023 at 05:28:25PM +0100, Catalin Marinas wrote:
On Thu, Sep 07, 2023 at 02:17:16PM +0000, Maximilian Heyne wrote:
With the recent removal of vm_dev from devres its memory is only freed via the callback virtio_mmio_release_dev. However, this only takes effect after device_add is called by register_virtio_device. Until then it's an unmanaged resource and must be explicitly freed on error exit.
This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
Cc: stable@vger.kernel.org Fixes: 55c91fedd03d ("virtio-mmio: don't break lifecycle of vm_dev") Signed-off-by: Maximilian Heyne mheyne@amazon.de
Reviewed-by: Catalin Marinas catalin.marinas@arm.com Tested-by: Catalin Marinas catalin.marinas@arm.com
Who would apply this patch?
The virtio maintainers (Michael, Jason).
Something seems to have choked my patch so it didn't reach lore.kernel.org (message couldn't be delivered due to timeout). Should I try to send it again?
You can send a v3 with the added acks. It's strange that it didn't make it to lore. I got it as I was cc'ed but checking the archives, it's not there.
linux-stable-mirror@lists.linaro.org
-
Catalin Marinas -
Maximilian Heyne