Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controler present on the MacBookPro16,2.
Cc: stable@vger.kernel.org Signed-off-by: Orlando Chamberlain redecorating@protonmail.com Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v3->v4: reviewed-by line
drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c54d19fb184c..a872b4485eac 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N */ + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */ { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
On Tue, 05 Oct 2021, Aditya Garg wrote:
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controler present on the MacBookPro16,2.
Cc: stable@vger.kernel.org Signed-off-by: Orlando Chamberlain redecorating@protonmail.com
Who is the author of this patch?
Why hasn't the submitter signed it off?
Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
v3->v4: reviewed-by line drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
diff
This is not a format I recognise.
Did you use `git send-email` to submit this?
--git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c54d19fb184c..a872b4485eac 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
/* ICL-N */
{ PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */ { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
From: Orlando Chamberlain redecorating@protonmail.com Subject: [Patch] Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controler present on the MacBookPro16,2.
Cc: stable@vger.kernel.org Signed-off-by: Orlando Chamberlain redecorating@protonmail.com Signed-off-by: Aditya Garg gargaditya08@live.com Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v3->v4: reviewed-by line
drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c54d19fb184c..a872b4485eac 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c
@@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
+ /* ICL-N */ + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
/* TGL-H */ { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
Entire message looks like a mess. Are you sure you are using proper tools for sending it?
On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
Entire message looks like a mess. Are you sure you are using proper tools for sending it?
Agreed.
I can't apply this until it's submitted properly.
- Please read Documentation/process/submitting-patches.rst - Please read Documentation/process/coding-style.rst
If you have any questions, please reach out. We're happy to help.
From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001 From: Orlando Chamberlain redecorating@protonmail.com Date: Fri, 1 Oct 2021 13:30:19 +0530 Subject: [PATCH] Add support for MacBookPro16,2 UART Cc: stable@vger.kernel.org
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
Signed-off-by: Aditya Garg gargaditya08@live.com --- drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c54d19fb1..33d5043fd 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info }, + /* ICL-N*/ + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info }, /* TGL-H */ { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
On 21-Oct-2021, at 4:45 PM, Lee Jones lee.jones@linaro.org wrote:
On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
Entire message looks like a mess. Are you sure you are using proper tools for sending it?
Agreed.
I can't apply this until it's submitted properly.
- Please read Documentation/process/submitting-patches.rst
- Please read Documentation/process/coding-style.rst
If you have any questions, please reach out. We're happy to help.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Fri, Oct 22, 2021 at 04:24:47AM +0000, Aditya Garg wrote:
From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001 From: Orlando Chamberlain redecorating@protonmail.com Date: Fri, 1 Oct 2021 13:30:19 +0530 Subject: [PATCH] Add support for MacBookPro16,2 UART Cc: stable@vger.kernel.org
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
Signed-off-by: Aditya Garg gargaditya08@live.com
drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
On Fri, 22 Oct 2021, Aditya Garg wrote:
From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001 From: Orlando Chamberlain redecorating@protonmail.com Date: Fri, 1 Oct 2021 13:30:19 +0530 Subject: [PATCH] Add support for MacBookPro16,2 UART Cc: stable@vger.kernel.org
What is this?
These headers should not be part of the patch.
How are you submitting this? What tools are you using? Did you read the documents I sent you (see below)?
Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.
This line is too long.
Signed-off-by: Aditya Garg gargaditya08@live.com
drivers/mfd/intel-lpss-pci.c | 2 ++ 1 file changed, 2 insertions(+)
This diff looks better.
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c index c54d19fb1..33d5043fd 100644 --- a/drivers/mfd/intel-lpss-pci.c +++ b/drivers/mfd/intel-lpss-pci.c @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
- /* ICL-N*/
- { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info }, /* TGL-H */ { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
On 21-Oct-2021, at 4:45 PM, Lee Jones lee.jones@linaro.org wrote:
On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
Entire message looks like a mess. Are you sure you are using proper tools for sending it?
Agreed.
I can't apply this until it's submitted properly.
- Please read Documentation/process/submitting-patches.rst
- Please read Documentation/process/coding-style.rst
If you have any questions, please reach out. We're happy to help.
This quoted text can't be part of a submitted patch.
Please submit the patch on its own, as a new thread, using the correct tooling (provided mostly by the Git package (i.e. `git format-patch` and `git send-email`).
If you're stuck, or there is something you do not understand, please ask.
linux-stable-mirror@lists.linaro.org
-
Aditya Garg -
andriy.shevchenko＠linux.intel.com -
Greg KH -
Lee Jones