When !CONFIG_VM_BUG_ON, there is warning of clang-analyzer-deadcode.DeadStores: Value stored to 'mt' during its initialization is never read.
Signed-off-by: Maria Yu quic_aiquny@quicinc.com --- mm/page_isolation.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 04141a9bea70..51d5c8025f77 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -330,9 +330,7 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, zone->zone_start_pfn);
if (skip_isolation) { - int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock)); - - VM_BUG_ON(!is_migrate_isolate(mt)); + VM_BUG_ON(!is_migrate_isolate(get_pageblock_migratetype(pfn_to_page(isolate_pageblock)))); } else { ret = set_migratetype_isolate(pfn_to_page(isolate_pageblock), migratetype, flags, isolate_pageblock, isolate_pageblock + pageblock_nr_pages);
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.' Subject: [PATCH] mm/page_isolation: fix clang deadcode warning Link: https://lore.kernel.org/stable/20221021030953.34925-1-quic_aiquny%40quicinc....
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
On Fri, Oct 21, 2022 at 11:09:53AM +0800, Maria Yu wrote:
When !CONFIG_VM_BUG_ON, there is warning of clang-analyzer-deadcode.DeadStores: Value stored to 'mt' during its initialization is never read.
Honestly, the cure is worse than the disease. I'd rather not have a line that's this long.
int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
VM_BUG_ON(!is_migrate_isolate(mt));
VM_BUG_ON(!is_migrate_isolate(get_pageblock_migratetype(pfn_to_page(isolate_pageblock))));
linux-stable-mirror@lists.linaro.org