On Fri, Apr 26, 2019 at 08:57:51PM +0200, Heiner Kallweit wrote:

On 26.04.2019 12:55, Rasmus Villemoes wrote:

...

After ed8fe20205ac (net: dsa: mv88e6xxx: prevent interrupt storm caused by mv88e6390x_port_set_cmode) got into 4.19-stable (as 4d8f5df0), a non-CONFIG_NET_DSA_LEGACY build warns

drivers/net/dsa/mv88e6xxx/chip.c:4635:13: warning: ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function]

I think 3acca1dd (net: dsa: mv88e6xxx: add call to mv88e6xxx_ports_cmode_init to probe for new DSA framework) should be added to the same stable trees that ed8fe20205ac was, at least 4.19.

That's right. Actually the referenced fix should have been applied to 4.19, not sure why this wasn't done. On 5.0 it was applied.

That's the confirmation from Dave that it was queued up for stable. https://marc.info/?l=linux-netdev&m=155173359712109&w=2

I've queued it for 4.19, thanks!

-- Thanks, Sasha