The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 25e5ef302c24a6fead369c0cfe88c073d7b97ca8 Mon Sep 17 00:00:00 2001
From: Jean Delvare jdelvare@suse.de Date: Sun, 28 Jul 2019 18:41:38 +0200 Subject: [PATCH] eeprom: at24: make spd world-readable again
The integration of the at24 driver into the nvmem framework broke the world-readability of spd EEPROMs. Fix it.
Signed-off-by: Jean Delvare jdelvare@suse.de Cc: stable@vger.kernel.org Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM framework") Cc: Andrew Lunn andrew@lunn.ch Cc: Srinivas Kandagatla srinivas.kandagatla@linaro.org Cc: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: Bartosz Golaszewski brgl@bgdev.pl Cc: Arnd Bergmann arnd@arndb.de Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 35bf2477693d..518945b2f737 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -685,7 +685,7 @@ static int at24_probe(struct i2c_client *client) nvmem_config.name = dev_name(dev); nvmem_config.dev = dev; nvmem_config.read_only = !writable; - nvmem_config.root_only = true; + nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO); nvmem_config.owner = THIS_MODULE; nvmem_config.compat = true; nvmem_config.base_dev = dev;
Hi Greg,
On Mon, 05 Aug 2019 07:25:48 +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.19-stable tree.
Technically it applies. Just it doesn't build ;-)
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The backport is trivial, I'll take care of it, thanks.
pon., 5 sie 2019 o 10:32 Jean Delvare jdelvare@suse.de napisał(a):
Hi Greg,
On Mon, 05 Aug 2019 07:25:48 +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.19-stable tree.
Technically it applies. Just it doesn't build ;-)
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The backport is trivial, I'll take care of it, thanks.
-- Jean Delvare SUSE L3 Support
Hi Jean,
I already sent backports for v4.9, v4.14 and v4.19 earlier today.
Bart
On Mon, Aug 05, 2019 at 10:35:41AM +0200, Bartosz Golaszewski wrote:
pon., 5 sie 2019 o 10:32 Jean Delvare jdelvare@suse.de napisał(a):
Hi Greg,
On Mon, 05 Aug 2019 07:25:48 +0200, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.19-stable tree.
Technically it applies. Just it doesn't build ;-)
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The backport is trivial, I'll take care of it, thanks.
-- Jean Delvare SUSE L3 Support
Hi Jean,
I already sent backports for v4.9, v4.14 and v4.19 earlier today.
Thanks for those, now queued up.
greg k-h
linux-stable-mirror@lists.linaro.org