WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
Cc: stable@vger.kernel.org Fixes: 83fae950c992 ("arm64: dts: qcom: sm8550-qrd: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts index 6c8e206080d2..76e9ca954093 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts @@ -842,7 +842,7 @@ &swr2 { wcd_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>; - qcom,tx-port-mapping = <1 1 2 3>; + qcom,tx-port-mapping = <2 2 3 4>; }; };
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Cc: stable@vger.kernel.org Fixes: a541667c86a9 ("arm64: dts: qcom: sm8550-mtp: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org --- arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index c2847fd3c209..393702fe61aa 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -745,7 +745,7 @@ &swr2 { wcd_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>; - qcom,tx-port-mapping = <1 1 2 3>; + qcom,tx-port-mapping = <2 2 3 4>; }; };
On 24/01/2024 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Cc: stable@vger.kernel.org Fixes: a541667c86a9 ("arm64: dts: qcom: sm8550-mtp: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index c2847fd3c209..393702fe61aa 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -745,7 +745,7 @@ &swr2 { wcd_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>;
qcom,tx-port-mapping = <1 1 2 3>;
qcom,tx-port-mapping = <2 2 3 4>;
Reviewed-by: Neil Armstrong neil.armstrong@linaro.org
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Would this not be codec-and-not-board-specific, anyway?
Cc: stable@vger.kernel.org Fixes: a541667c86a9 ("arm64: dts: qcom: sm8550-mtp: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Reviewed-by: Konrad Dybcio konrad.dybcio@linaro.org
Konrad
On 25/01/2024 10:59, Konrad Dybcio wrote:
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Would this not be codec-and-not-board-specific, anyway?
Yes, indeed, it should be.
Best regards, Krzysztof
On 1/25/24 11:43, Krzysztof Kozlowski wrote:
On 25/01/2024 10:59, Konrad Dybcio wrote:
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Would this not be codec-and-not-board-specific, anyway?
Yes, indeed, it should be.
Should we move this to the driver and drop the then-uselesss dt property?
Konrad
On 25/01/2024 11:47, Konrad Dybcio wrote:
On 1/25/24 11:43, Krzysztof Kozlowski wrote:
On 25/01/2024 10:59, Konrad Dybcio wrote:
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Would this not be codec-and-not-board-specific, anyway?
Yes, indeed, it should be.
Should we move this to the driver and drop the then-uselesss dt property?
Actually it's codec-and-soc specific, so I'm against dropping this.
On the sc8280xp & sc7280 it requires a different mapping because the TX macro changed the way to map the soundwire channels since (at least) SM8450.
Neil
Konrad
On 1/25/24 14:02, neil.armstrong@linaro.org wrote:
On 25/01/2024 11:47, Konrad Dybcio wrote:
On 1/25/24 11:43, Krzysztof Kozlowski wrote:
On 25/01/2024 10:59, Konrad Dybcio wrote:
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
The change is based on QRD8550 and should be correct here as well, but was not tested on MTP8550.
Would this not be codec-and-not-board-specific, anyway?
Yes, indeed, it should be.
Should we move this to the driver and drop the then-uselesss dt property?
Actually it's codec-and-soc specific, so I'm against dropping this.
Aaaah snap :(
Let's leave it as-is then.
Konrad
On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
Cc: stable@vger.kernel.org Fixes: 83fae950c992 ("arm64: dts: qcom: sm8550-qrd: add WCD9385 audio-codec") Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
That matches what I believe to be the corresponding part in the DT!
Reviewed-by: Konrad Dybcio konrad.dybcio@linaro.org
Konrad
On Wed, 24 Jan 2024 17:45:02 +0100, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact it is offset by one. Correct it to fix recording via analogue microphones.
Applied, thanks!
[1/4] arm64: dts: qcom: sm8550-qrd: correct WCD9385 TX port mapping commit: 8ca7fbd92c1b28edb5d5df7aeb8bb4886ddb9829 [2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping commit: b66966b1bbc0aa58f7af83cbd56d5a206892857c [3/4] arm64: dts: qcom: sm8550-qrd: add correct analogue microphones commit: e2f1a18747b1bcb48900290d8f4de13e2ee55cbb [4/4] arm64: dts: qcom: sm8550-mtp: add correct analogue microphones commit: 503c0129b3aaf2aaf481ffd7f0a422af8a18f0b9
Best regards,
linux-stable-mirror@lists.linaro.org
-
Bjorn Andersson -
Konrad Dybcio -
Krzysztof Kozlowski -
neil.armstrong＠linaro.org