Hi Greg,
These two patches should probably be part of the 4.4 because ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") backport. 4.9, 4.14 and 4.16 have these patches already in it.
Romain Izard (1): serial: mctrl_gpio: Add missing module license
Uwe Kleine-König (1): serial: mctrl_gpio: export mctrl_gpio_disable_ms and mctrl_gpio_init
drivers/tty/serial/serial_mctrl_gpio.c | 5 +++++ 1 file changed, 5 insertions(+)
From: Uwe Kleine-König u.kleine-koenig@pengutronix.de
To be able to make use of the mctrl-gpio helper from a module these functions must be exported. This was forgotten in the commit introducing support interrupt handling for these functions (while it was done for mctrl_gpio_enable_ms, *sigh*).
Fixes: ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/tty/serial/serial_mctrl_gpio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c index 3eb57eb532f1..226ad23b136c 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.c +++ b/drivers/tty/serial/serial_mctrl_gpio.c @@ -193,6 +193,7 @@ struct mctrl_gpios *mctrl_gpio_init(struct uart_port *port, unsigned int idx)
return gpios; } +EXPORT_SYMBOL_GPL(mctrl_gpio_init);
void mctrl_gpio_free(struct device *dev, struct mctrl_gpios *gpios) { @@ -247,3 +248,4 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios) disable_irq(gpios->irq[i]); } } +EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
From: Romain Izard romain.izard.pro@gmail.com
As the mctrl_gpio driver can be built as a module, it needs to have its license specified with MODULE_LICENSE. Otherwise, it cannot access required symbols exported through EXPORT_SYMBOL_GPL.
Signed-off-by: Romain Izard romain.izard.pro@gmail.com Acked-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/tty/serial/serial_mctrl_gpio.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c index 226ad23b136c..02147361eaa9 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.c +++ b/drivers/tty/serial/serial_mctrl_gpio.c @@ -20,6 +20,7 @@ #include <linux/gpio/consumer.h> #include <linux/termios.h> #include <linux/serial_core.h> +#include <linux/module.h>
#include "serial_mctrl_gpio.h"
@@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios) } } EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms); + +MODULE_LICENSE("GPL");
On Mon, Apr 30, 2018 at 09:46:20AM +0200, Daniel Wagner wrote:
Hi Greg,
These two patches should probably be part of the 4.4 because ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") backport. 4.9, 4.14 and 4.16 have these patches already in it.
Romain Izard (1): serial: mctrl_gpio: Add missing module license
Uwe Kleine-König (1): serial: mctrl_gpio: export mctrl_gpio_disable_ms and mctrl_gpio_init
drivers/tty/serial/serial_mctrl_gpio.c | 5 +++++ 1 file changed, 5 insertions(+)
What are the git commit ids of these patches in Linus's tree? It's a pain for me to have to dig them out...
On Mon, Apr 30, 2018 at 10:52:02AM -0700, Greg KH wrote:
On Mon, Apr 30, 2018 at 09:46:20AM +0200, Daniel Wagner wrote:
Hi Greg,
These two patches should probably be part of the 4.4 because ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") backport. 4.9, 4.14 and 4.16 have these patches already in it.
Romain Izard (1): serial: mctrl_gpio: Add missing module license
Uwe Kleine-König (1): serial: mctrl_gpio: export mctrl_gpio_disable_ms and mctrl_gpio_init
drivers/tty/serial/serial_mctrl_gpio.c | 5 +++++ 1 file changed, 5 insertions(+)
What are the git commit ids of these patches in Linus's tree? It's a pain for me to have to dig them out...
Nevermind, I found them...
linux-stable-mirror@lists.linaro.org
-
Daniel Wagner -
Greg KH