From: Rafał Miłecki rafal@milecki.pl
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later.
This fixes info passed to the userspace. Without that change userspace could try to use invalid channel and fail to start an interface.
Signed-off-by: Rafał Miłecki rafal@milecki.pl Cc: stable@vger.kernel.org --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 230a378c26fc..7f0a5bade70a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -6005,7 +6005,8 @@ static int brcmf_construct_chaninfo(struct brcmf_cfg80211_info *cfg, * for subsequent chanspecs. */ channel->flags = IEEE80211_CHAN_NO_HT40 | - IEEE80211_CHAN_NO_80MHZ; + IEEE80211_CHAN_NO_80MHZ | + IEEE80211_CHAN_NO_160MHZ; ch.bw = BRCMU_CHAN_BW_20; cfg->d11inf.encchspec(&ch); chaninfo = ch.chspec;
Rafał Miłecki zajec5@gmail.com writes:
From: Rafał Miłecki rafal@milecki.pl
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later.
This fixes info passed to the userspace. Without that change userspace could try to use invalid channel and fail to start an interface.
Signed-off-by: Rafał Miłecki rafal@milecki.pl Cc: stable@vger.kernel.org
Should this be queued to 4.20?
On 2018-11-09 15:05, Kalle Valo wrote:
Rafał Miłecki zajec5@gmail.com writes:
From: Rafał Miłecki rafal@milecki.pl
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later.
This fixes info passed to the userspace. Without that change userspace could try to use invalid channel and fail to start an interface.
Signed-off-by: Rafał Miłecki rafal@milecki.pl Cc: stable@vger.kernel.org
Should this be queued to 4.20?
That's my suggestion.
I try to mark fixes (patches for currently developed release) with an extra FIX tag in a subject. Do you see those when using your patchwork tool? Do you have any other method in mind that would be preferred by you?
Rafał Miłecki rafal@milecki.pl writes:
On 2018-11-09 15:05, Kalle Valo wrote:
Rafał Miłecki zajec5@gmail.com writes:
From: Rafał Miłecki rafal@milecki.pl
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later.
This fixes info passed to the userspace. Without that change userspace could try to use invalid channel and fail to start an interface.
Signed-off-by: Rafał Miłecki rafal@milecki.pl Cc: stable@vger.kernel.org
Should this be queued to 4.20?
That's my suggestion.
Ok, I'll queue this for 4.20.
Rafał Miłecki wrote:
From: Rafał Miłecki rafal@milecki.pl
Driver can report IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ so it's important to provide valid & complete info about supported bands for each channel. By default no support for 160 MHz should be assumed unless firmware reports it for a given channel later.
This fixes info passed to the userspace. Without that change userspace could try to use invalid channel and fail to start an interface.
Signed-off-by: Rafał Miłecki rafal@milecki.pl Cc: stable@vger.kernel.org
Patch applied to wireless-drivers.git, thanks.
d1fe6ad6f6bd brcmfmac: fix reporting support for 160 MHz channels
linux-stable-mirror@lists.linaro.org
-
Kalle Valo -
Rafał Miłecki -
Rafał Miłecki