On 2020-12-29 9:54 a.m., Deucher, Alexander wrote:

[AMD Public Use]

I don't know if these fixes related to modifiers make sense in the pre-modifier code base.  Bas, Nick?

Alex

Mesa should be the only userspace trying to make use of DCC and it doesn't do it for video formats. From the kernel side of things we've also never supported this and you'd get corruption on the screen if you tried.

It's a "fix" for both pre-modifiers and post-modifiers code.

Regards, Nicholas Kazlauskas

---

*From:* amd-gfx amd-gfx-bounces@lists.freedesktop.org on behalf of Sasha Levin sashal@kernel.org *Sent:* Tuesday, December 22, 2020 9:16 PM *To:* linux-kernel@vger.kernel.org linux-kernel@vger.kernel.org; stable@vger.kernel.org stable@vger.kernel.org *Cc:* Sasha Levin sashal@kernel.org; dri-devel@lists.freedesktop.org dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org amd-gfx@lists.freedesktop.org; Bas Nieuwenhuizen bas@basnieuwenhuizen.nl; Deucher, Alexander Alexander.Deucher@amd.com; Kazlauskas, Nicholas Nicholas.Kazlauskas@amd.com *Subject:* [PATCH AUTOSEL 5.4 006/130] drm/amd/display: Do not silently accept DCC for multiplane formats. From: Bas Nieuwenhuizen bas@basnieuwenhuizen.nl

[ Upstream commit b35ce7b364ec80b54f48a8fdf9fb74667774d2da ]

Silently accepting it could result in corruption.

Signed-off-by: Bas Nieuwenhuizen bas@basnieuwenhuizen.nl Reviewed-by: Alex Deucher alexander.deucher@amd.com Reviewed-by: Nicholas Kazlauskas nicholas.kazlauskas@amd.com Signed-off-by: Alex Deucher alexander.deucher@amd.com Signed-off-by: Sasha Levin sashal@kernel.org

---

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index d2dd387c95d86..ce70c42a2c3ec 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2734,7 +2734,7 @@ fill_plane_dcc_attributes(struct amdgpu_device *adev,                  return 0;

if (format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN) -               return 0; +               return -EINVAL;

if (!dc->cap_funcs.get_dcc_compression_cap)                  return -EINVAL; -- 2.27.0

---

amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free... https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cfb9f2581393f494acd1708d8a6e905fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637442867044150000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZYz1FjTl6SoWX1B91t0McdUai%2FzRF9C8uBmE%2BNQNod4%3D&reserved=0