From: Johan Hovold johan@kernel.org
In case device registration fails during probe, the driver state and the embedded platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).
Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card") Link: https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org Cc: stable@vger.kernel.org # 2.6.38 Signed-off-by: Johan Hovold johan@kernel.org Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de --- drivers/net/can/softing/softing_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c index 2e93ee792373..e5c939b63fa6 100644 --- a/drivers/net/can/softing/softing_cs.c +++ b/drivers/net/can/softing/softing_cs.c @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia) return 0;
platform_failed: - kfree(dev); + platform_device_put(pdev); mem_failed: pcmcia_bad: pcmcia_failed:
base-commit: 6dc9a23e29061e50c36523270de60039ccf536fa
Hello:
This series was applied to netdev/net.git (master) by Marc Kleine-Budde mkl@pengutronix.de:
On Sun, 9 Jan 2022 14:40:36 +0100 you wrote:
From: Johan Hovold johan@kernel.org
In case device registration fails during probe, the driver state and the embedded platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).
[...]
Here is the summary with links: - [net,1/5] can: softing_cs: softingcs_probe(): fix memleak on registration failure https://git.kernel.org/netdev/net/c/ced4913efb0a - [net,2/5] can: softing: softing_startstop(): fix set but not used variable warning https://git.kernel.org/netdev/net/c/370d988cc529 - [net,3/5] can: xilinx_can: xcan_probe(): check for error irq https://git.kernel.org/netdev/net/c/c6564c13dae2 - [net,4/5] can: rcar_canfd: rcar_canfd_channel_probe(): make sure we free CAN network device https://git.kernel.org/netdev/net/c/72b1e360572f - [net,5/5] can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} https://git.kernel.org/netdev/net/c/89d58aebe14a
You are awesome, thank you!
linux-stable-mirror@lists.linaro.org