Issue: As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL macro in ISR will always be false leads to irq polling non-functional.
Fix: Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Chandrakanth Patil chandrakanth.patil@broadcom.com Signed-off-by: Kashyap Desai kashyap.desai@broadcom.com --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index bb34278..0824410 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3740,10 +3740,8 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp) if (instance->mask_interrupts) return IRQ_NONE;
-#if defined(ENABLE_IRQ_POLL) if (irq_context->irq_poll_scheduled) return IRQ_HANDLED; -#endif
if (!instance->msix_vectors) { mfiStatus = instance->instancet->clear_intr(instance);
On Wed, Jul 15, 2020 at 05:26:30PM +0530, Chandrakanth Patil wrote:
Issue: As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL macro in ISR will always be false leads to irq polling non-functional.
Fix: Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Chandrakanth Patil chandrakanth.patil@broadcom.com Signed-off-by: Kashyap Desai kashyap.desai@broadcom.com
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 -- 1 file changed, 2 deletions(-)
Why are you not sending this to the scsi developers / maintainers?
thanks,
greg k-h
Hi Greg,
Sorry for the inconvenience. While circulating patch internally (within company) with cc stable enabled in patch header has caused this problem. I have sent a new patch including appropriate scsi developers and maintainers.
Thanks, Chandrakanth Patil
On Wed, Jul 15, 2020 at 5:21 AM Greg KH greg@kroah.com wrote:
On Wed, Jul 15, 2020 at 05:26:30PM +0530, Chandrakanth Patil wrote:
Issue: As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL macro in ISR will always be false leads to irq polling non-functional.
Fix: Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Chandrakanth Patil chandrakanth.patil@broadcom.com Signed-off-by: Kashyap Desai kashyap.desai@broadcom.com
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 -- 1 file changed, 2 deletions(-)
Why are you not sending this to the scsi developers / maintainers?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org