In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
thanks,
greg k-h
On Fri, 10 Jun 2022 07:15:37 +0200 Greg KH greg@kroah.com wrote:
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
On Fri, 10 Jun 2022 18:25:23 -0700 Jason Self jason@bluehome.net wrote:
On Fri, 10 Jun 2022 07:15:37 +0200 Greg KH greg@kroah.com wrote:
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
The result of my git bisect between 5.15.44 and 5.15.45 tell me the following. It's the same "lib/crypto: add prompts back to crypto libraries" commit when I bisect between 5.10.119 and 5.10.120.
e16cc79b0f916069de223bdb567fa0bc2ccd18a5 is the first bad commit commit e16cc79b0f916069de223bdb567fa0bc2ccd18a5 Author: Justin M. Forbes jforbes@fedoraproject.org Date: Thu Jun 2 22:23:23 2022 +0200
lib/crypto: add prompts back to crypto libraries
commit e56e18985596617ae426ed5997fb2e737cffb58b upstream.
Commit 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") took away a number of prompt texts from other crypto libraries. This makes values flip from built-in to module when oldconfig runs, and causes problems when these crypto libs need to be built in for thingslike BIG_KEYS.
Fixes: 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") Cc: Herbert Xu herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org [Jason: - moved menu into submenu of lib/ instead of root menu - fixed chacha sub-dependencies for CONFIG_CRYPTO] Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
crypto/Kconfig | 2 -- lib/Kconfig | 2 ++ lib/crypto/Kconfig | 17 ++++++++++++----- 3 files changed, 14 insertions(+), 7 deletions(-) bisect run success
On Fri, Jun 10, 2022 at 06:42:55PM -0700, Jason Self wrote:
On Fri, 10 Jun 2022 18:25:23 -0700 Jason Self jason@bluehome.net wrote:
On Fri, 10 Jun 2022 07:15:37 +0200 Greg KH greg@kroah.com wrote:
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
The result of my git bisect between 5.15.44 and 5.15.45 tell me the following. It's the same "lib/crypto: add prompts back to crypto libraries" commit when I bisect between 5.10.119 and 5.10.120.
e16cc79b0f916069de223bdb567fa0bc2ccd18a5 is the first bad commit commit e16cc79b0f916069de223bdb567fa0bc2ccd18a5 Author: Justin M. Forbes jforbes@fedoraproject.org Date: Thu Jun 2 22:23:23 2022 +0200
lib/crypto: add prompts back to crypto librariescommit e56e18985596617ae426ed5997fb2e737cffb58b upstream. Commit 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") took away a number of prompt texts from other crypto libraries. This makes values flip from built-in to module when oldconfig runs, and causes problems when these crypto libs need to be built in for thingslike BIG_KEYS. Fixes: 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") Cc: Herbert Xu herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org [Jason: - moved menu into submenu of lib/ instead of root menu - fixed chacha sub-dependencies for CONFIG_CRYPTO] Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
crypto/Kconfig | 2 -- lib/Kconfig | 2 ++ lib/crypto/Kconfig | 17 ++++++++++++----- 3 files changed, 14 insertions(+), 7 deletions(-) bisect run success
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
- Eric
Hi Herbert,
On Fri, Jun 10, 2022 at 08:09:24PM -0700, Eric Biggers wrote:
On Fri, Jun 10, 2022 at 06:42:55PM -0700, Jason Self wrote:
On Fri, 10 Jun 2022 18:25:23 -0700 Jason Self jason@bluehome.net wrote:
On Fri, 10 Jun 2022 07:15:37 +0200 Greg KH greg@kroah.com wrote:
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
The result of my git bisect between 5.15.44 and 5.15.45 tell me the following. It's the same "lib/crypto: add prompts back to crypto libraries" commit when I bisect between 5.10.119 and 5.10.120.
e16cc79b0f916069de223bdb567fa0bc2ccd18a5 is the first bad commit commit e16cc79b0f916069de223bdb567fa0bc2ccd18a5 Author: Justin M. Forbes jforbes@fedoraproject.org Date: Thu Jun 2 22:23:23 2022 +0200
lib/crypto: add prompts back to crypto librariescommit e56e18985596617ae426ed5997fb2e737cffb58b upstream. Commit 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") took away a number of prompt texts from other crypto libraries. This makes values flip from built-in to module when oldconfig runs, and causes problems when these crypto libs need to be built in for thingslike BIG_KEYS. Fixes: 6048fdcc5f269 ("lib/crypto: blake2s: include as built-in") Cc: Herbert Xu herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org [Jason: - moved menu into submenu of lib/ instead of root menu - fixed chacha sub-dependencies for CONFIG_CRYPTO] Signed-off-by: Jason A. Donenfeld Jason@zx2c4.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
crypto/Kconfig | 2 -- lib/Kconfig | 2 ++ lib/crypto/Kconfig | 17 ++++++++++++----- 3 files changed, 14 insertions(+), 7 deletions(-) bisect run success
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
Both of these commits:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/co... https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/co...
were marked as "[PATCH crypto]", rather than cryptodev, have a CC to stable@, and have a fixes tag. So I think these would be better slated for the crypto tree rather than the cryptodev tree, so that they make it to Linus soonish.
Jason
On Fri, Jun 10, 2022 at 08:09:24PM -0700, Eric Biggers wrote:
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
OK I have added it to the crypto tree.
Thanks,
Hi Herbert,
On Sun, Jun 12, 2022 at 02:57:26PM +0800, Herbert Xu wrote:
On Fri, Jun 10, 2022 at 08:09:24PM -0700, Eric Biggers wrote:
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
OK I have added it to the crypto tree.
Could you do the same with https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/co... It fixes a similar bug.
Jason
Thanks,
Email: Herbert Xu herbert@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Sun, Jun 12, 2022 at 10:16:50AM +0200, Jason A. Donenfeld wrote:
Hi Herbert,
On Sun, Jun 12, 2022 at 02:57:26PM +0800, Herbert Xu wrote:
On Fri, Jun 10, 2022 at 08:09:24PM -0700, Eric Biggers wrote:
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
OK I have added it to the crypto tree.
Could you do the same with https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/co... It fixes a similar bug.
Sorry, that one is a bit too big for my taste. If this issue is so critical that we must fix it right away can you please do a minimal patch?
Thanks,
On Mon, Jun 13, 2022 at 05:45:52PM +0800, Herbert Xu wrote:
On Sun, Jun 12, 2022 at 10:16:50AM +0200, Jason A. Donenfeld wrote:
Hi Herbert,
On Sun, Jun 12, 2022 at 02:57:26PM +0800, Herbert Xu wrote:
On Fri, Jun 10, 2022 at 08:09:24PM -0700, Eric Biggers wrote:
It looks like "crypto: memneq - move into lib/" is going to fix this (https://lore.kernel.org/linux-crypto/20220528102429.189731-1-Jason@zx2c4.com). At the moment it's queued in cryptodev/master. Herbert, are you planning to send it upstream soon?
OK I have added it to the crypto tree.
Could you do the same with https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/co... It fixes a similar bug.
Sorry, that one is a bit too big for my taste. If this issue is so critical that we must fix it right away can you please do a minimal patch?
Up to you. (I don't intend to work on a different patch.)
Thanks,
Email: Herbert Xu herbert@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 6/11/22 08:25, Jason Self wrote:
On Fri, 10 Jun 2022 07:15:37 +0200 Greg KH greg@kroah.com wrote:
On Thu, Jun 09, 2022 at 04:29:43PM -0700, Jason Self wrote:
In building 5.15.46 & 5.10.121 with CRYPTO_LIB_CURVE25519=m I get the following. My workaround is to leave it as CRYPTO_LIB_CURVE25519=n for now.
CONFIG_OR1K_1200=y CONFIG_OPENRISC_BUILTIN_DTB="or1ksim"
sed 's/.ko$/.o/' modules.order | scripts/mod/modpost -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__crypto_memneq" [lib/crypto/libcurve25519.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Is this a new problem, or has it always been there for these kernel trees?
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
What did you answer for that new config?
On Sat, 11 Jun 2022 14:29:53 +0700 Bagas Sanjaya bagasdotme@gmail.com wrote:
It's new; it began in 5.15.45 & 5.10.120, which is when make oldconfig first prompted about CONFIG_CRYPTO_LIB_CURVE25519.
What did you answer for that new config?
Initially "m" but "y" also seems to not matter. With "y":
or1k-linux-ld: lib/crypto/curve25519-selftest.o: in function `curve25519_selftest': curve25519-selftest.c:(.init.text+0x7c): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x7c): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `__crypto_memneq' or1k-linux-ld: curve25519-selftest.c:(.init.text+0x110): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x110): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `__crypto_memneq' or1k-linux-ld: curve25519-selftest.c:(.init.text+0x140): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x140): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `__crypto_memneq' or1k-linux-ld: curve25519-selftest.c:(.init.text+0x188): undefined reference to `__crypto_memneq' curve25519-selftest.c:(.init.text+0x188): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `__crypto_memneq' make: *** [Makefile:1183: vmlinux] Error 1
linux-stable-mirror@lists.linaro.org
-
Bagas Sanjaya -
Eric Biggers -
Greg KH -
Herbert Xu -
Jason A. Donenfeld -
Jason Self