Hi, with Michael, we realized that this patch merged upstream solves an issue in the device emulation in the vhost-vsock module. Before this patch, the emulation did not meet the VIRTIO vsock specification, assuming that the buffer in the RX virtqueue was always 4 KB, without checking the actual size.
Please, backport the following patch to fix this issue:
commit 6dbd3e66e7785a2f055bf84d98de9b8fd31ff3f5 Author: Stefano Garzarella sgarzare@redhat.com Date: Tue Jul 30 17:43:33 2019 +0200
vhost/vsock: split packets to send using multiple buffers
If the packets to sent to the guest are bigger than the buffer available, we can split them, using multiple buffers and fixing the length in the packet header. This is safe since virtio-vsock supports only stream sockets.
Signed-off-by: Stefano Garzarella sgarzare@redhat.com Reviewed-by: Stefan Hajnoczi stefanha@redhat.com Acked-by: Michael S. Tsirkin mst@redhat.com Signed-off-by: David S. Miller davem@davemloft.net
The commit applies and builds against 4.14, 4.19, and 5.3
Thanks, Stefano
On Mon, Nov 25, 2019 at 04:39:00PM +0100, Stefano Garzarella wrote:
Hi, with Michael, we realized that this patch merged upstream solves an issue in the device emulation in the vhost-vsock module. Before this patch, the emulation did not meet the VIRTIO vsock specification, assuming that the buffer in the RX virtqueue was always 4 KB, without checking the actual size.
Please, backport the following patch to fix this issue:
commit 6dbd3e66e7785a2f055bf84d98de9b8fd31ff3f5 Author: Stefano Garzarella sgarzare@redhat.com Date: Tue Jul 30 17:43:33 2019 +0200
vhost/vsock: split packets to send using multiple buffers
If the packets to sent to the guest are bigger than the buffer available, we can split them, using multiple buffers and fixing the length in the packet header. This is safe since virtio-vsock supports only stream sockets. Signed-off-by: Stefano Garzarella sgarzare@redhat.com Reviewed-by: Stefan Hajnoczi stefanha@redhat.com Acked-by: Michael S. Tsirkin mst@redhat.com Signed-off-by: David S. Miller davem@davemloft.net
The commit applies and builds against 4.14, 4.19, and 5.3
Now queud up, thanks.
greg k-h
linux-stable-mirror@lists.linaro.org