Since addition of the multicolor LED framework in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") the color property becomes required even if the multicolor framework is not enabled and used.
Fix the binding documentation to reflect the real state.
Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: stable@vger.kernel.org Cc: Pavel Machek pavel@ucw.cz Cc: Jacek Anaszewski jacek.anaszewski@gmail.com Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč michal.vokac@ysoft.com --- Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml index f552cd143d5b..e6bdd1cb615a 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml @@ -101,6 +101,7 @@ patternProperties: description: name of channel
required: + - color - compatible - reg
@@ -127,6 +128,7 @@ examples: chan-name = "d1"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_RED>; };
led@1 { @@ -134,6 +136,7 @@ examples: chan-name = "d2"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_BLUE>; };
led@2 { @@ -141,6 +144,7 @@ examples: chan-name = "d3"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_GREEN>; };
led@3 { @@ -148,6 +152,7 @@ examples: chan-name = "d4"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_RED>; };
led@4 { @@ -155,6 +160,7 @@ examples: chan-name = "d5"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_BLUE>; };
led@5 { @@ -162,6 +168,7 @@ examples: chan-name = "d6"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_GREEN>; };
led@6 { @@ -169,6 +176,7 @@ examples: chan-name = "d7"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_RED>; };
led@7 { @@ -176,6 +184,7 @@ examples: chan-name = "d8"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_BLUE>; };
led@8 { @@ -183,6 +192,7 @@ examples: chan-name = "d9"; led-cur = /bits/ 8 <0x14>; max-cur = /bits/ 8 <0x20>; + color = <LED_COLOR_ID_GREEN>; }; };
On Fri, 14 May 2021 16:44:36 +0200, Michal Vokáč wrote:
Since addition of the multicolor LED framework in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") the color property becomes required even if the multicolor framework is not enabled and used.
Fix the binding documentation to reflect the real state.
Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: stable@vger.kernel.org Cc: Pavel Machek pavel@ucw.cz Cc: Jacek Anaszewski jacek.anaszewski@gmail.com Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč michal.vokac@ysoft.com
Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp55xx.example.dt.yaml: led-controller@32: 'color' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp55xx.example.dt.yaml: led-controller@33: 'color' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
See https://patchwork.ozlabs.org/patch/1478502
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
linux-stable-mirror@lists.linaro.org