It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") cc: stable@vger.kernel.org Suggested-by: Hongliang Yang hongliang.yang@cixtech.com Signed-off-by: Peter Chen peter.chen@cixtech.com --- drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c index fd06cb85c4ea..757fdd918286 100644 --- a/drivers/usb/cdns3/cdnsp-ring.c +++ b/drivers/usb/cdns3/cdnsp-ring.c @@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id) }
if (port_id != old_port) { - cdnsp_disable_slot(pdev); + if (pdev->slot_id) + cdnsp_disable_slot(pdev); + pdev->active_port = port; cdnsp_enable_slot(pdev); }
发件人: Peter Chen peter.chen@cixtech.com 发送时间: 2025年6月18日 17:53
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") cc: stable@vger.kernel.org Suggested-by: Hongliang Yang hongliang.yang@cixtech.com Signed-off-by: Peter Chen peter.chen@cixtech.com
Reviewed-by: Fugang Duan fugang.duan@cixtech.com
drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c index fd06cb85c4ea..757fdd918286 100644 --- a/drivers/usb/cdns3/cdnsp-ring.c +++ b/drivers/usb/cdns3/cdnsp-ring.c @@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id) }
if (port_id != old_port) {
cdnsp_disable_slot(pdev);
if (pdev->slot_id)cdnsp_disable_slot(pdev);- pdev->active_port = port; cdnsp_enable_slot(pdev); }
-- 2.25.1
On Wed, Jun 18, 2025 at 05:53:21PM +0800, Peter Chen wrote:
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") cc: stable@vger.kernel.org Suggested-by: Hongliang Yang hongliang.yang@cixtech.com Signed-off-by: Peter Chen peter.chen@cixtech.com
drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Any reason this wasn't cc:ed the proper mailing lists?
Or is this a stable-kernel-only patch?
confused,
greg k-h
On 25-07-01 11:34:46, Greg KH wrote:
[Some people who received this message don't often get email from gregkh@linuxfoundation.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
EXTERNAL EMAIL
On Wed, Jun 18, 2025 at 05:53:21PM +0800, Peter Chen wrote:
It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") cc: stable@vger.kernel.org Suggested-by: Hongliang Yang hongliang.yang@cixtech.com Signed-off-by: Peter Chen peter.chen@cixtech.com
drivers/usb/cdns3/cdnsp-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Any reason this wasn't cc:ed the proper mailing lists?
Or is this a stable-kernel-only patch?
confused,
Sorry, Greg. This is internal review patch for upstream, I forgot to omit cc list when sending review. Please ignore it.
The formal upstream patch has already sent out to linux-usb mail list.
linux-stable-mirror@lists.linaro.org
-
Fugang Duan -
Greg KH -
Peter Chen