On 1970/1/1 8:00, wrote:
6.6-stable review patch. If anyone has any objections, please let me know.
From Hans de Goede hdegoede@redhat.com
[ Upstream commit 936e4d49ecbc8c404790504386e1422b599dec39 ]
There have been multiple reports of keyboard issues on recent laptop models which can be worked around by setting i8042.dumbkbd, with the downside being this breaks the capslock LED.
It seems that these issues are caused by recent laptops getting confused by ATKBD_CMD_GETID. Rather then adding and endless growing list of quirks for this, just skip ATKBD_CMD_GETID alltogether on laptops in translated mode.
The main goal of sending ATKBD_CMD_GETID is to skip binding to ps2 micetouchpads and those are never used in translated mode.
Examples of laptop models which benefit from skipping ATKBD_CMD_GETID
HP Laptop 15s-fq2xxx, HP laptop 15s-fq4xxx and HP Laptop 15-dy2xxx models the kbd stops working for the first 2 - 5 minutes after boot (waiting for EC watchdog reset)
On HP Spectre x360 13-aw2xxx atkbd fails to probe the keyboard
At least 9 different Lenovo models have issues with ATKBD_CMD_GETID, see httpsgithub.comyescallopatkbd-nogetid
This has been tested on
A MSI B550M PRO-VDH WIFI desktop, where the i8042 controller is not in translated mode when no keyboard is plugged in and with a ps2 kbd a AT Translated Set 2 keyboard devinputevent# node shows up
A Lenovo ThinkPad X1 Yoga gen 8 (always has a translated set 2 keyboard)
Reported-by Shang Ye yesh25@mail2.sysu.edu.cn Closes httpslore.kernel.orglinux-input886D6167733841AE+20231017135318.11142-1-yesh25@mail2.sysu.edu.cn Closes httpsgithub.comyescallopatkbd-nogetid Reported-by gurevitch mail@gurevit.ch Closes httpslore.kernel.orglinux-input2iAJTwqZV6lQs26cTb38RNYqxvsink6SRmrZ5h0cBUSuf9NT0tZTsf9fEAbbto2maavHJEOP8GA1evlKa6xjKOsaskDhtJWxjcnrgPigzVo=@gurevit.ch Reported-by Egor Ignatov egori@altlinux.org Closes httpslore.kernel.orgall20210609073333.8425-1-egori@altlinux.org Reported-by Anton Zhilyaev anton@cpp.in Closes httpslore.kernel.orglinux-input20210201160336.16008-1-anton@cpp.in Closes httpsbugzilla.redhat.comshow_bug.cgiid=2086156 Signed-off-by Hans de Goede hdegoede@redhat.com Link httpslore.kernel.orgr20231115174625.7462-1-hdegoede@redhat.com Signed-off-by Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by Sasha Levin sashal@kernel.org
Hi, Hans
I noticed there's a subsequent bugfix [1] for this patch, but it hasn't been merged into the stable-6.6 branch. Based on the bugfix description, the issue should exist there as well. Would you like this patch to be merged into the stable-6.6 branch?"
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Hi,
On 14-Jul-25 15:49, Wang Hai wrote:
On 1970/1/1 8:00, wrote:
6.6-stable review patch. If anyone has any objections, please let me know.
From Hans de Goede hdegoede@redhat.com
[ Upstream commit 936e4d49ecbc8c404790504386e1422b599dec39 ]
There have been multiple reports of keyboard issues on recent laptop models which can be worked around by setting i8042.dumbkbd, with the downside being this breaks the capslock LED.
It seems that these issues are caused by recent laptops getting confused by ATKBD_CMD_GETID. Rather then adding and endless growing list of quirks for this, just skip ATKBD_CMD_GETID alltogether on laptops in translated mode.
The main goal of sending ATKBD_CMD_GETID is to skip binding to ps2 micetouchpads and those are never used in translated mode.
Examples of laptop models which benefit from skipping ATKBD_CMD_GETID
HP Laptop 15s-fq2xxx, HP laptop 15s-fq4xxx and HP Laptop 15-dy2xxx models the kbd stops working for the first 2 - 5 minutes after boot (waiting for EC watchdog reset)
On HP Spectre x360 13-aw2xxx atkbd fails to probe the keyboard
At least 9 different Lenovo models have issues with ATKBD_CMD_GETID, see httpsgithub.comyescallopatkbd-nogetid
This has been tested on
- A MSI B550M PRO-VDH WIFI desktop, where the i8042 controller is not
in translated mode when no keyboard is plugged in and with a ps2 kbd a AT Translated Set 2 keyboard devinputevent# node shows up
- A Lenovo ThinkPad X1 Yoga gen 8 (always has a translated set 2 keyboard)
Reported-by Shang Ye yesh25@mail2.sysu.edu.cn Closes httpslore.kernel.orglinux-input886D6167733841AE+20231017135318.11142-1-yesh25@mail2.sysu.edu.cn Closes httpsgithub.comyescallopatkbd-nogetid Reported-by gurevitch mail@gurevit.ch Closes httpslore.kernel.orglinux-input2iAJTwqZV6lQs26cTb38RNYqxvsink6SRmrZ5h0cBUSuf9NT0tZTsf9fEAbbto2maavHJEOP8GA1evlKa6xjKOsaskDhtJWxjcnrgPigzVo=@gurevit.ch Reported-by Egor Ignatov egori@altlinux.org Closes httpslore.kernel.orgall20210609073333.8425-1-egori@altlinux.org Reported-by Anton Zhilyaev anton@cpp.in Closes httpslore.kernel.orglinux-input20210201160336.16008-1-anton@cpp.in Closes httpsbugzilla.redhat.comshow_bug.cgiid=2086156 Signed-off-by Hans de Goede hdegoede@redhat.com Link httpslore.kernel.orgr20231115174625.7462-1-hdegoede@redhat.com Signed-off-by Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by Sasha Levin sashal@kernel.org
Hi, Hans
I noticed there's a subsequent bugfix [1] for this patch, but it hasn't been merged into the stable-6.6 branch. Based on the bugfix description, the issue should exist there as well. Would you like this patch to be merged into the stable-6.6 branch?"
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Yes, if you can submit that patch for inclusion into the 6.6 stable branch that would be good.
Regards,
Hans
On 2025/7/14 22:40, Hans de Goede wrote:
Hi,
On 14-Jul-25 15:49, Wang Hai wrote:
On 1970/1/1 8:00, wrote:
6.6-stable review patch. If anyone has any objections, please let me know.
From Hans de Goede hdegoede@redhat.com
[ Upstream commit 936e4d49ecbc8c404790504386e1422b599dec39 ]
There have been multiple reports of keyboard issues on recent laptop models which can be worked around by setting i8042.dumbkbd, with the downside being this breaks the capslock LED.
It seems that these issues are caused by recent laptops getting confused by ATKBD_CMD_GETID. Rather then adding and endless growing list of quirks for this, just skip ATKBD_CMD_GETID alltogether on laptops in translated mode.
The main goal of sending ATKBD_CMD_GETID is to skip binding to ps2 micetouchpads and those are never used in translated mode.
Examples of laptop models which benefit from skipping ATKBD_CMD_GETID
HP Laptop 15s-fq2xxx, HP laptop 15s-fq4xxx and HP Laptop 15-dy2xxx models the kbd stops working for the first 2 - 5 minutes after boot (waiting for EC watchdog reset)
On HP Spectre x360 13-aw2xxx atkbd fails to probe the keyboard
At least 9 different Lenovo models have issues with ATKBD_CMD_GETID, see httpsgithub.comyescallopatkbd-nogetid
This has been tested on
- A MSI B550M PRO-VDH WIFI desktop, where the i8042 controller is not
in translated mode when no keyboard is plugged in and with a ps2 kbd a AT Translated Set 2 keyboard devinputevent# node shows up
- A Lenovo ThinkPad X1 Yoga gen 8 (always has a translated set 2 keyboard)
Reported-by Shang Ye yesh25@mail2.sysu.edu.cn Closes httpslore.kernel.orglinux-input886D6167733841AE+20231017135318.11142-1-yesh25@mail2.sysu.edu.cn Closes httpsgithub.comyescallopatkbd-nogetid Reported-by gurevitch mail@gurevit.ch Closes httpslore.kernel.orglinux-input2iAJTwqZV6lQs26cTb38RNYqxvsink6SRmrZ5h0cBUSuf9NT0tZTsf9fEAbbto2maavHJEOP8GA1evlKa6xjKOsaskDhtJWxjcnrgPigzVo=@gurevit.ch Reported-by Egor Ignatov egori@altlinux.org Closes httpslore.kernel.orgall20210609073333.8425-1-egori@altlinux.org Reported-by Anton Zhilyaev anton@cpp.in Closes httpslore.kernel.orglinux-input20210201160336.16008-1-anton@cpp.in Closes httpsbugzilla.redhat.comshow_bug.cgiid=2086156 Signed-off-by Hans de Goede hdegoede@redhat.com Link httpslore.kernel.orgr20231115174625.7462-1-hdegoede@redhat.com Signed-off-by Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by Sasha Levin sashal@kernel.org
Hi, Hans
I noticed there's a subsequent bugfix [1] for this patch, but it hasn't been merged into the stable-6.6 branch. Based on the bugfix description, the issue should exist there as well. Would you like this patch to be merged into the stable-6.6 branch?"
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Yes, if you can submit that patch for inclusion into the 6.6 stable branch that would be good.
Regards,
Hans
Hi, Hans
I noticed that the 5.4, 5.10, 5.15, 6.1, and 6.6 stable branches all require this. I’ve just submitted the fix patch—could you review it when you have time?
https://lore.kernel.org/stable/20250715031442.16528-1-wanghai38@huawei.com/T...
Regards,
Wang Hai
linux-stable-mirror@lists.linaro.org
-
Hans de Goede -
Wang Hai