For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value.
It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status.
Signed-off-by: Tokunori Ikegami ikegami@allied-telesis.co.jp Reviewed-by: Joakim Tjernlund Joakim.Tjernlund@infinera.com Cc: Chris Packham chris.packham@alliedtelesis.co.nz Cc: Brian Norris computersforpeace@gmail.com Cc: David Woodhouse dwmw2@infradead.org Cc: Boris Brezillon boris.brezillon@free-electrons.com Cc: Marek Vasut marek.vasut@gmail.com Cc: Richard Weinberger richard@nod.at Cc: Cyrille Pitchen cyrille.pitchen@wedev4u.fr Cc: linux-mtd@lists.infradead.org Cc: stable@vger.kernel.org Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com --- drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 692902df2598..9ab521d25ea2 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1880,7 +1880,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, if (time_after(jiffies, timeo) && !chip_ready(map, adr)) break;
- if (chip_ready(map, adr)) { + if (chip_good(map, adr, datum)) { xip_enable(map, chip, adr); goto op_done; }
On Mon, Jul 02, 2018 at 11:50:42AM +0900, Tokunori Ikegami wrote:
For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value.
It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status.
Signed-off-by: Tokunori Ikegami ikegami@allied-telesis.co.jp Reviewed-by: Joakim Tjernlund Joakim.Tjernlund@infinera.com Cc: Chris Packham chris.packham@alliedtelesis.co.nz Cc: Brian Norris computersforpeace@gmail.com Cc: David Woodhouse dwmw2@infradead.org Cc: Boris Brezillon boris.brezillon@free-electrons.com Cc: Marek Vasut marek.vasut@gmail.com Cc: Richard Weinberger richard@nod.at Cc: Cyrille Pitchen cyrille.pitchen@wedev4u.fr Cc: linux-mtd@lists.infradead.org Cc: stable@vger.kernel.org Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com
drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What are the git commit ids for all of these patches, and what stable tree do they need to go to?
thanks,
greg k-h
Hi Greg-san,
The commit IDs on mainline are below.
1. dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check correct value 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The patches just sent today as revised are only existing with commit IDs on my local environment. Also the patches are existing on the Linux MTD development patchwork as below but the commit IDs are not assigned. https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133
If those revised patches should be applied anywhere to have commit IDs at first please let me know. Probably it should be consulted with the MTD maintainer Boris-san.
Regards, Ikegami
-----Original Message----- From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] Sent: Monday, July 02, 2018 3:19 PM To: IKEGAMI Tokunori Cc: PACKHAM Chris; Brian Norris; David Woodhouse; Boris Brezillon; Marek Vasut; Richard Weinberger; Cyrille Pitchen; linux-mtd@lists.infradead.org; stable@vger.kernel.org; Boris Brezillon Subject: Re: [PATCH 1/4] mtd: cfi_cmdset_0002: Change write buffer to check correct value
On Mon, Jul 02, 2018 at 11:50:42AM +0900, Tokunori Ikegami wrote:
For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value.
It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status.
Signed-off-by: Tokunori Ikegami ikegami@allied-telesis.co.jp Reviewed-by: Joakim Tjernlund Joakim.Tjernlund@infinera.com Cc: Chris Packham chris.packham@alliedtelesis.co.nz Cc: Brian Norris computersforpeace@gmail.com Cc: David Woodhouse dwmw2@infradead.org Cc: Boris Brezillon boris.brezillon@free-electrons.com Cc: Marek Vasut marek.vasut@gmail.com Cc: Richard Weinberger richard@nod.at Cc: Cyrille Pitchen cyrille.pitchen@wedev4u.fr Cc: linux-mtd@lists.infradead.org Cc: stable@vger.kernel.org Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com
drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What are the git commit ids for all of these patches, and what stable tree do they need to go to?
thanks,
greg k-h
On Mon, Jul 02, 2018 at 07:16:47AM +0000, IKEGAMI Tokunori wrote:
Hi Greg-san,
The commit IDs on mainline are below.
- dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check correct value
- 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation
- 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error
- 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The patches just sent today as revised are only existing with commit IDs on my local environment. Also the patches are existing on the Linux MTD development patchwork as below but the commit IDs are not assigned. https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133
If those revised patches should be applied anywhere to have commit IDs at first please let me know. Probably it should be consulted with the MTD maintainer Boris-san.
And what stable tree(s) do you want to see these applied to?
thanks,
greg k-h
The 1 patch below has been added to review into the following 5 trees.
Patch: 1. dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check correct value
Tree: 1. 3.18-stable 2. 4.4-stable 3. 4.9-stable 4. 4.14-stable 5. 4.17-stable
So please applied the remaining 3 patches below as same.
Patch: 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The commit IDs are on mainline so there are not existed for revised version patches.
-----Original Message----- From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] Sent: Monday, July 02, 2018 4:23 PM To: IKEGAMI Tokunori Cc: PACKHAM Chris; Brian Norris; David Woodhouse; Boris Brezillon; Marek Vasut; Richard Weinberger; Cyrille Pitchen; linux-mtd@lists.infradead.org; stable@vger.kernel.org; Boris Brezillon Subject: Re: [PATCH 1/4] mtd: cfi_cmdset_0002: Change write buffer to check correct value
On Mon, Jul 02, 2018 at 07:16:47AM +0000, IKEGAMI Tokunori wrote:
Hi Greg-san,
The commit IDs on mainline are below.
- dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check
correct value
- 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to
retry write operation
- 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to
retry for error
- 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to
check chip good only
Note: The patches just sent today as revised are only existing with commit
IDs on my local environment.
Also the patches are existing on the Linux MTD development patchwork
as below but the commit IDs are not assigned.
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133
If those revised patches should be applied anywhere to have commit
IDs at first please let me know.
Probably it should be consulted with the MTD maintainer Boris-san.
And what stable tree(s) do you want to see these applied to?
thanks,
greg k-h
Hi Greg-san,
Let me confirm below. About the patches 2, 3 and 4 below still should I prepare the commit IDs for revised version? Or those can be added to the stable trees next time without commit IDs?
Patch: 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The commit IDs are on mainline so there are not existed for revised version patches.
I think that the patches revised version are still existing on the linux-mtd Patchwork without commit IDs. https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133&state=*
Sorry for this confirmation but I am not sure how to resolve this to apply these revised version patches to stable trees.
Regards, Ikegami
-----Original Message----- From: IKEGAMI Tokunori Sent: Monday, July 02, 2018 4:34 PM To: 'Greg Kroah-Hartman' Cc: PACKHAM Chris; Brian Norris; David Woodhouse; Boris Brezillon; Marek Vasut; Richard Weinberger; Cyrille Pitchen; linux-mtd@lists.infradead.org; stable@vger.kernel.org; Boris Brezillon Subject: RE: [PATCH 1/4] mtd: cfi_cmdset_0002: Change write buffer to check correct value
The 1 patch below has been added to review into the following 5 trees.
Patch: 1. dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check correct value
Tree: 1. 3.18-stable 2. 4.4-stable 3. 4.9-stable 4. 4.14-stable 5. 4.17-stable
So please applied the remaining 3 patches below as same.
Patch: 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The commit IDs are on mainline so there are not existed for revised version patches.
-----Original Message----- From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] Sent: Monday, July 02, 2018 4:23 PM To: IKEGAMI Tokunori Cc: PACKHAM Chris; Brian Norris; David Woodhouse; Boris Brezillon;
Marek
Vasut; Richard Weinberger; Cyrille Pitchen; linux-mtd@lists.infradead.org; stable@vger.kernel.org; Boris Brezillon Subject: Re: [PATCH 1/4] mtd: cfi_cmdset_0002: Change write buffer to check correct value
On Mon, Jul 02, 2018 at 07:16:47AM +0000, IKEGAMI Tokunori wrote:
Hi Greg-san,
The commit IDs on mainline are below.
- dfeae1073583 mtd: cfi_cmdset_0002: Change write buffer to check
correct value
- 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to
retry write operation
- 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to
retry for error
- 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to
check chip good only
Note: The patches just sent today as revised are only existing with commit
IDs on my local environment.
Also the patches are existing on the Linux MTD development
patchwork
as below but the commit IDs are not assigned.
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133
If those revised patches should be applied anywhere to have commit
IDs at first please let me know.
Probably it should be consulted with the MTD maintainer Boris-san.
And what stable tree(s) do you want to see these applied to?
thanks,
greg k-h
On Fri, Jul 06, 2018 at 10:11:39AM +0000, IKEGAMI Tokunori wrote:
Hi Greg-san,
Let me confirm below. About the patches 2, 3 and 4 below still should I prepare the commit IDs for revised version? Or those can be added to the stable trees next time without commit IDs?
Patch: 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The commit IDs are on mainline so there are not existed for revised version patches.
I think that the patches revised version are still existing on the linux-mtd Patchwork without commit IDs. https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133&state=*
Sorry for this confirmation but I am not sure how to resolve this to apply these revised version patches to stable trees.
Ok, I think I have it figured out now. Look at what I have queued up to the stable queues to verify I got it correct.
thanks,
greg k-h
Hi Greg-san,
Thank you so much for the mail. I have just confirmed that the queued patches are correct.
Regards, Ikegami
-----Original Message----- From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org] On Behalf Of Greg Kroah-Hartman Sent: Tuesday, July 10, 2018 11:46 PM To: IKEGAMI Tokunori Cc: PACKHAM Chris; Brian Norris; David Woodhouse; Boris Brezillon; Marek Vasut; Richard Weinberger; Cyrille Pitchen; linux-mtd@lists.infradead.org; stable@vger.kernel.org; Boris Brezillon Subject: Re: [PATCH 1/4] mtd: cfi_cmdset_0002: Change write buffer to check correct value
On Fri, Jul 06, 2018 at 10:11:39AM +0000, IKEGAMI Tokunori wrote:
Hi Greg-san,
Let me confirm below. About the patches 2, 3 and 4 below still should I prepare the commit IDs
for revised version?
Or those can be added to the stable trees next time without commit IDs?
Patch: 2. 85a82e28b023 mtd: cfi_cmdset_0002: Change definition naming to retry write operation 3. 45f75b8a919a mtd: cfi_cmdset_0002: Change erase functions to retry for error 4. 79ca484b6130 mtd: cfi_cmdset_0002: Change erase functions to check chip good only
Note: The commit IDs are on mainline so there are not existed for revised version patches.
I think that the patches revised version are still existing on the linux-mtd
Patchwork without commit IDs.
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=53133&state= *
Sorry for this confirmation but I am not sure how to resolve this to apply
these revised version patches to stable trees.
Ok, I think I have it figured out now. Look at what I have queued up to the stable queues to verify I got it correct.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg Kroah-Hartman -
IKEGAMI Tokunori -
Tokunori Ikegami