Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. Without this the PHY link is detected properly and ethtool statistics for TX are increasing but there's no RX traffic coming in.
Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: stable@vger.kernel.org Suggested-by: Hauke Mehrtens hauke@hauke-m.de Signed-off-by: Martin Blumenstingl martin.blumenstingl@googlemail.com --- drivers/net/dsa/lantiq_gswip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 09701c17f3f6..5d378c8026f0 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1541,9 +1541,7 @@ static void gswip_phylink_mac_link_up(struct dsa_switch *ds, int port, { struct gswip_priv *priv = ds->priv;
- /* Enable the xMII interface only for the external PHY */ - if (interface != PHY_INTERFACE_MODE_INTERNAL) - gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port); + gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port); }
static void gswip_get_strings(struct dsa_switch *ds, int port, u32 stringset,
Hi Andrew,
On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn andrew@lunn.ch wrote:
do you recommend re-sending these patches and changing the subject? the lantiq_gswip.c driver is identical in -net and -net-next and so the patch will apply fine in both cases
Best regards, Martin
Hi Jakub,
On Mon, Jan 4, 2021 at 10:52 PM Jakub Kicinski kuba@kernel.org wrote:
awesome, thank you! :-)
Best regards, Martin
On 1/2/21 5:25 PM, Martin Blumenstingl wrote:
Reviewed-by: Florian Fainelli f.fainelli@gmail.com
linux-stable-mirror@lists.linaro.org
-
Andrew Lunn -
Florian Fainelli -
Hauke Mehrtens -
Jakub Kicinski -
Martin Blumenstingl