Some older systems still compile kernels with old gcc version.
$ grep -B3 "^GNU C" linux-5.10.223-rc1/Documentation/Changes ====================== =============== ======================================== Program Minimal version Command to check the version ====================== =============== ======================================== GNU C 4.9 gcc --version
These warnings and errors show up when compiling with gcc 4.9.2
UPD include/config/kernel.release UPD include/generated/uapi/linux/version.h UPD include/generated/utsrelease.h CC scripts/mod/empty.o In file included from ././include/linux/compiler_types.h:65:0, from <command-line>:0: ./include/linux/compiler_attributes.h:29:29: warning: "__GCC4_has_attribute___uninitialized__" is not defined [-Wundef] # define __has_attribute(x) __GCC4_has_attribute_##x ^ ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute' #if __has_attribute(__uninitialized__) ^ [SNIP] AR arch/x86/events/built-in.a CC arch/x86/kvm/../../../virt/kvm/kvm_main.o In file included from ././include/linux/compiler_types.h:65:0, from <command-line>:0: ./include/linux/compiler_attributes.h:29:29: error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef] # define __has_attribute(x) __GCC4_has_attribute_##x ^ ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute' #if __has_attribute(__uninitialized__) ^ cc1: all warnings being treated as errors make[2]: *** [scripts/Makefile.build:286: arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1 make[1]: *** [scripts/Makefile.build:503: arch/x86/kvm] Error 2 make: *** [Makefile:1832: arch/x86] Error 2
Following patch fixes this. Upstream won't need this because newer kernels are not compilable with gcc 4.9
--- ./include/linux/compiler_attributes.h.OLD +++ ./include/linux/compiler_attributes.h @@ -37,6 +37,7 @@ # define __GCC4_has_attribute___nonstring__ 0 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) +# define __GCC4_has_attribute___uninitialized__ 0 # define __GCC4_has_attribute___fallthrough__ 0 # define __GCC4_has_attribute___warning__ 1 #endif
Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro" Signed-off-by: Jari Ruusu jariruusu@protonmail.com
-- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
Some older systems still compile kernels with old gcc version.
$ grep -B3 "^GNU C" linux-5.10.223-rc1/Documentation/Changes ====================== =============== ======================================== Program Minimal version Command to check the version ====================== =============== ======================================== GNU C 4.9 gcc --version
These warnings and errors show up when compiling with gcc 4.9.2
UPD include/config/kernel.release UPD include/generated/uapi/linux/version.h UPD include/generated/utsrelease.h CC scripts/mod/empty.o In file included from ././include/linux/compiler_types.h:65:0, from <command-line>:0: ./include/linux/compiler_attributes.h:29:29: warning: "__GCC4_has_attribute___uninitialized__" is not defined [-Wundef] # define __has_attribute(x) __GCC4_has_attribute_##x ^ ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute' #if __has_attribute(__uninitialized__) ^ [SNIP] AR arch/x86/events/built-in.a CC arch/x86/kvm/../../../virt/kvm/kvm_main.o In file included from ././include/linux/compiler_types.h:65:0, from <command-line>:0: ./include/linux/compiler_attributes.h:29:29: error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef] # define __has_attribute(x) __GCC4_has_attribute_##x ^ ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute' #if __has_attribute(__uninitialized__) ^ cc1: all warnings being treated as errors make[2]: *** [scripts/Makefile.build:286: arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1 make[1]: *** [scripts/Makefile.build:503: arch/x86/kvm] Error 2 make: *** [Makefile:1832: arch/x86] Error 2
Following patch fixes this. Upstream won't need this because newer kernels are not compilable with gcc 4.9
--- ./include/linux/compiler_attributes.h.OLD +++ ./include/linux/compiler_attributes.h @@ -37,6 +37,7 @@ # define __GCC4_has_attribute___nonstring__ 0 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) +# define __GCC4_has_attribute___uninitialized__ 0 # define __GCC4_has_attribute___fallthrough__ 0 # define __GCC4_has_attribute___warning__ 1 #endif
Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro" Signed-off-by: Jari Ruusu jariruusu@protonmail.com
Please submit this in a format in which we can apply it, thanks!
greg k-h
On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro" Signed-off-by: Jari Ruusu jariruusu@protonmail.com
Please submit this in a format in which we can apply it, thanks!
Protonmail seems to involuntarily inject mime-poop to outgoing mails. Sorry about that. For the time being, the best I can do is to re-send the patch as gzipped attachment.
-- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
On Fri, Jul 26, 2024 at 08:21:47AM +0000, Jari Ruusu wrote:
On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro" Signed-off-by: Jari Ruusu jariruusu@protonmail.com
Please submit this in a format in which we can apply it, thanks!
Protonmail seems to involuntarily inject mime-poop to outgoing mails. Sorry about that. For the time being, the best I can do is to re-send the patch as gzipped attachment.
For obvious reasons, we can't take that either :(
Also the "Fixes:" tag is not in the correct format, please fix that up at the very least.
thanks,
greg k-h
On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
Also the "Fixes:" tag is not in the correct format, please fix that up at the very least.
Some older systems still compile kernels with old gcc version. These warnings and errors show up when compiling with gcc 4.9.2
error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
Following patch fixes this. Upstream won't need this because newer kernels are not compilable with gcc 4.9.
Subject: gcc-4.9 warning/error fix for 5.10.223-rc1 Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro") Signed-off-by: Jari Ruusu jariruusu@protonmail.com
--- ./include/linux/compiler_attributes.h.OLD +++ ./include/linux/compiler_attributes.h @@ -37,6 +37,7 @@ # define __GCC4_has_attribute___nonstring__ 0 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) +# define __GCC4_has_attribute___uninitialized__ 0 # define __GCC4_has_attribute___fallthrough__ 0 # define __GCC4_has_attribute___warning__ 1 #endif
-- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
On Fri, Jul 26, 2024 at 09:53:18AM +0000, Jari Ruusu wrote:
On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
Also the "Fixes:" tag is not in the correct format, please fix that up at the very least.
Some older systems still compile kernels with old gcc version. These warnings and errors show up when compiling with gcc 4.9.2
error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
Following patch fixes this. Upstream won't need this because newer kernels are not compilable with gcc 4.9.
Subject: gcc-4.9 warning/error fix for 5.10.223-rc1 Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro") Signed-off-by: Jari Ruusu jariruusu@protonmail.com
--- ./include/linux/compiler_attributes.h.OLD +++ ./include/linux/compiler_attributes.h @@ -37,6 +37,7 @@ # define __GCC4_has_attribute___nonstring__ 0 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) +# define __GCC4_has_attribute___uninitialized__ 0 # define __GCC4_has_attribute___fallthrough__ 0 # define __GCC4_has_attribute___warning__ 1 #endif
-- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
Better, thanks! I'll touch this up by hand and apply it to the relevant branches (not just this one needs it), for the next round of stable releases.
greg k-h
On Fri, Jul 26, 2024 at 12:23:02PM +0200, Greg Kroah-Hartman wrote:
On Fri, Jul 26, 2024 at 09:53:18AM +0000, Jari Ruusu wrote:
On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
Also the "Fixes:" tag is not in the correct format, please fix that up at the very least.
Some older systems still compile kernels with old gcc version. These warnings and errors show up when compiling with gcc 4.9.2
error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
Following patch fixes this. Upstream won't need this because newer kernels are not compilable with gcc 4.9.
Subject: gcc-4.9 warning/error fix for 5.10.223-rc1 Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro") Signed-off-by: Jari Ruusu jariruusu@protonmail.com
--- ./include/linux/compiler_attributes.h.OLD +++ ./include/linux/compiler_attributes.h @@ -37,6 +37,7 @@ # define __GCC4_has_attribute___nonstring__ 0 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8) # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9) +# define __GCC4_has_attribute___uninitialized__ 0 # define __GCC4_has_attribute___fallthrough__ 0 # define __GCC4_has_attribute___warning__ 1 #endif
-- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
Better, thanks! I'll touch this up by hand and apply it to the relevant branches (not just this one needs it), for the next round of stable releases.
Now queued up.
greg k-h
On Friday, July 26, 2024 14:22 IST, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Fri, Jul 26, 2024 at 08:21:47AM +0000, Jari Ruusu wrote:
On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro" Signed-off-by: Jari Ruusu jariruusu@protonmail.com
Please submit this in a format in which we can apply it, thanks!
Protonmail seems to involuntarily inject mime-poop to outgoing mails. Sorry about that. For the time being, the best I can do is to re-send the patch as gzipped attachment.
For obvious reasons, we can't take that either :(
Also the "Fixes:" tag is not in the correct format, please fix that up at the very least.
thanks,
greg k-h
KernelCI report for stable-rc/linux-5.10.y for this week. Date: 2024-07-25
## Build failures: No build failures seen for the stable-rc/linux-5.10.y commit head \o/
## Boot failures: No **new** boot failures seen for the stable-rc/linux-5.10.y commit head \o/
Tested-by: kernelci.org bot bot@kernelci.org
Thanks, Shreeya Patel
linux-stable-mirror@lists.linaro.org
-
Greg Kroah-Hartman -
Jari Ruusu -
Shreeya Patel