Fix the default value for the register that set the resistance: it has to be 0x10.
Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") Cc: stable@vger.kernel.org Signed-off-by: Gwendal Grignou gwendal@chromium.org --- Changes since v2: - no changes
Changes since v1: - new patch.
drivers/iio/proximity/sx9324.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 0d9bbbb50cb45..d50ce67aafdf2 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -70,7 +70,8 @@ #define SX9324_REG_AFE_PH2 0x2a #define SX9324_REG_AFE_PH3 0x2b #define SX9324_REG_AFE_CTRL8 0x2c -#define SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM 0x02 +#define SX9324_REG_AFE_CTRL8_RSVD 0x10 +#define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02 #define SX9324_REG_AFE_CTRL9 0x2d #define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08
@@ -781,7 +782,8 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { { SX9324_REG_AFE_PH2, 0x1a }, { SX9324_REG_AFE_PH3, 0x16 },
- { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM }, + { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RSVD | + SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM }, { SX9324_REG_AFE_CTRL9, SX9324_REG_AFE_CTRL9_AGAIN_1 },
{ SX9324_REG_PROX_CTRL0, SX9324_REG_PROX_CTRL0_GAIN_1 |
Quoting Gwendal Grignou (2022-03-25 15:08:20)
Fix the default value for the register that set the resistance: it has to be 0x10.
Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") Cc: stable@vger.kernel.org Signed-off-by: Gwendal Grignou gwendal@chromium.org
I'd appreciate if you can carry forward tags next time. Then I know where to focus on things that have changed.
Reviewed-by: Stephen Boyd swboyd@chromium.org
On Sat, Mar 26, 2022 at 12:34 AM Gwendal Grignou gwendal@chromium.org wrote:
Fix the default value for the register that set the resistance: it has to be 0x10.
Has to be according to what? Datasheet? Reverse engineering?
...
+#define SX9324_REG_AFE_CTRL8_RSVD 0x10
Seems like a BIT() mask here. Also I don't think it's a good idea to put RSVD. Does it mean "reserved"? Is it really how it's written in the datasheet?
linux-stable-mirror@lists.linaro.org