Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
It was reported that the above commit was causing users of gcc < 4.9 to observe -Werror=missing-prototypes errors.
Indeed, it seems that: extern inline unsigned long native_save_fl(void) { return 0; }
compiled with -Werror=missing-prototypes produces this warning in gcc < 4.9, but not gcc >= 4.9.
Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4 Reported-by: David Laight david.laight@aculab.com Reported-by: Jean Delvare jdelvare@suse.de Signed-off-by: Nick Desaulniers ndesaulniers@google.com --- arch/x86/include/asm/irqflags.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h index c4fc17220df9..c14f2a74b2be 100644 --- a/arch/x86/include/asm/irqflags.h +++ b/arch/x86/include/asm/irqflags.h @@ -13,6 +13,8 @@ * Interrupt control: */
+/* Declaration required for gcc < 4.9 to prevent -Werror=missing-prototypes */ +extern inline unsigned long native_save_fl(void); extern inline unsigned long native_save_fl(void) { unsigned long flags;
From: Nick Desaulniers
Sent: 03 August 2018 18:06 Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
It was reported that the above commit was causing users of gcc < 4.9 to observe -Werror=missing-prototypes errors.
Indeed, it seems that: extern inline unsigned long native_save_fl(void) { return 0; }
compiled with -Werror=missing-prototypes produces this warning in gcc < 4.9, but not gcc >= 4.9.
Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4 Reported-by: David Laight david.laight@aculab.com Reported-by: Jean Delvare jdelvare@suse.de Signed-off-by: Nick Desaulniers ndesaulniers@google.com
You can add my:
Tested-by: David Laight david.laight@acuab.com
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
On Mon, Aug 6, 2018 at 12:25 PM, David Laight David.Laight@aculab.com wrote:
From: Nick Desaulniers
Sent: 03 August 2018 18:06 Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
It was reported that the above commit was causing users of gcc < 4.9 to observe -Werror=missing-prototypes errors.
Indeed, it seems that: extern inline unsigned long native_save_fl(void) { return 0; }
compiled with -Werror=missing-prototypes produces this warning in gcc < 4.9, but not gcc >= 4.9.
Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4 Reported-by: David Laight david.laight@aculab.com Reported-by: Jean Delvare jdelvare@suse.de Signed-off-by: Nick Desaulniers ndesaulniers@google.com
You can add my:
Tested-by: David Laight david.laight@acuab.com
Tested-by: Sedat Dilek sedat.dilek@gmail.com
On top of Linux v4.18-rc8 with clang version 7.0.0-svn338205.
- sed@ -
linux-stable-mirror@lists.linaro.org