The gpiolib debugfs interface exports a list of all gpio chips in a system and the state of their pins.

The gpio chip sections are supposed to be separated by a newline character, but a long-standing bug prevents the separator from being included when output is generated in multiple sessions, making the output inconsistent and hard to read.

Make sure to only suppress the newline separator at the beginning of the file as intended.

Fixes: f9c4a31f6150 ("gpiolib: Use seq_file's iterator interface") Cc: stable@vger.kernel.org # 3.7 Cc: Thierry Reding treding@nvidia.com Signed-off-by: Johan Hovold johan+linaro@kernel.org --- drivers/gpio/gpiolib.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index d5952ab7752c..e27488a90bc9 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4926,6 +4926,8 @@ static void *gpiolib_seq_start(struct seq_file *s, loff_t *pos) return NULL;

s->private = priv; + if (*pos > 0) + priv->newline = true; priv->idx = srcu_read_lock(&gpio_devices_srcu);

list_for_each_entry_srcu(gdev, &gpio_devices, list,