[PATCH v4 1/1] test_fimware: return -ENOMEM instead of -ENOSPC on failed memory allocation - Linux-stable-mirror

12 Aug 2023

[ Upstream commit 7dae593cd226a0bca61201cf85ceb9335cf63682 ]
In a couple of situations like
name = kstrndup(buf, count, GFP_KERNEL);
    if (!name)
    	return -ENOSPC;
the error is not actually "No space left on device", but "Out of memory".
It is semantically correct to return -ENOMEM in all failed kstrndup()
and kzalloc() cases in this driver, as it is not a problem with disk
space, but with kernel memory allocator failing allocation.
The semantically correct should be:
name = kstrndup(buf, count, GFP_KERNEL);
        if (!name)
                return -ENOMEM;
Cc: Dan Carpenter error27@gmail.com
Cc: Takashi Iwai tiwai@suse.de
Cc: Kees Cook keescook@chromium.org
Cc: Luis R. Rodriguez mcgrof@kernel.org
Cc: Brian Norris computersforpeace@gmail.com
Cc: stable@vger.kernel.org # 4.14
Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
Fixes: 0a8adf584759c ("test: add firmware_class loader test")
Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger")
Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger")
Link: https://lore.kernel.org/all/20230606070808.9300-1-mirsad.todorovac@alu.unizg...
Signed-off-by: Mirsad Todorovac mirsad.todorovac@alu.unizg.hr
[ This is the backport of the patch to 4.19 and 4.14 branches. There are no	]
[ semantic differences in the commit. Backport is provided for completenes sake	]
[ so it would apply to all of the supported LTS kernels				]
---
v3 -> v4:
 no changes. resubmitting for 4.14 because the patchwork didn't apply to the 4.14 tree.
v2 -> v3:
 minor clarifications with the versioning for the patchwork. no change to commit.
v1 -> v2:
 removed the Reviewed-by: and Acked-by tags, as this is a slightly different patch and
 those need to be reacquired
lib/test_firmware.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index 5318c5e18acf..34210306ea66 100644
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -159,7 +159,7 @@ static int __kstrncpy(char **dst, const char *name, size_t count, gfp_t gfp)
 {
    *dst = kstrndup(name, count, gfp);
    if (!*dst)
-		return -ENOSPC;
+		return -ENOMEM;
    return count;
 }
@@ -459,7 +459,7 @@ static ssize_t trigger_request_store(struct device *dev,
name = kstrndup(buf, count, GFP_KERNEL);
    if (!name)
-		return -ENOSPC;
+		return -ENOMEM;
pr_info("loading '%s'\n", name);
@@ -500,7 +500,7 @@ static ssize_t trigger_async_request_store(struct device *dev,
name = kstrndup(buf, count, GFP_KERNEL);
    if (!name)
-		return -ENOSPC;
+		return -ENOMEM;
pr_info("loading '%s'\n", name);
@@ -543,7 +543,7 @@ static ssize_t trigger_custom_fallback_store(struct device *dev,
name = kstrndup(buf, count, GFP_KERNEL);
    if (!name)
-		return -ENOSPC;
+		return -ENOMEM;
pr_info("loading '%s' using custom fallback mechanism\n", name);
-- 
2.34.1


    