On Mon, Feb 25, 2019 at 02:12:39PM -0600, Corey Wright wrote:

The recently released 3.18.137-rc1 stable-rc version fails to compile because commit "netfilter: nf_tables: fix flush after rule deletion in the same batch" references a macro that doesn't yet exist in 3.18. I believe this problem also exists in 4.4 and might be addressed with s/nft_is_active_next/nft_rule_is_active_next/.

3.18.137-rc1 (Git HEAD b336d186) contains commit c00e84e3 which introduces a reference to the "nft_is_active_next" macro which isn't defined in 3.18.

net/netfilter/nf_tables_api.c: In function 'nft_delrule_by_chain': net/netfilter/nf_tables_api.c:284:3: error: implicit declaration of function 'nft_is_active_next' [-Werror=implicit-function-declaration] if (!nft_is_active_next(ctx->net, rule)) ^

The nft_is_active_next macro doesn't even exist in the 4.4 stable tree and not until 4.9, where the commit "netfilter: nf_tables: add generic macros to check for generation mask" refactored the nft_rule_is_active_next static inline function to the nft_is_active_next macro.

Yes, this was my fault, I fixed this up after about 30 minutes of it being posted, sorry about that.

greg k-h