This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4.
Prerequisite revert for the reverting of the original commit f49449fbc21e.
Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment") Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Reported-by: Ferry Toth fntoth@gmail.com Cc: stable@vger.kernel.org --- drivers/usb/gadget/function/u_ether.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index 11dd0b9e847f..aa0511c3a62c 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -1163,8 +1163,6 @@ struct net_device *gether_connect(struct gether *link) if (netif_running(dev->net)) eth_start(dev, GFP_ATOMIC);
- netif_device_attach(dev->net); - /* on error, disable any endpoints */ } else { (void) usb_ep_disable(link->out_ep);
On Thu, Jun 06, 2024 at 11:02:31PM +0200, Ferry Toth wrote:
This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4.
Prerequisite revert for the reverting of the original commit f49449fbc21e.
Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment") Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Reported-by: Ferry Toth fntoth@gmail.com Cc: stable@vger.kernel.org
drivers/usb/gadget/function/u_ether.c | 2 -- 1 file changed, 2 deletions(-)
You have to sign-off on your changes, otherwise the tools will reject them (as will I). Please fix up for both of these and resend.
thanks,
greg k-h
Hi Greg,
Op 20-06-2024 om 19:35 schreef Greg Kroah-Hartman:
On Thu, Jun 06, 2024 at 11:02:31PM +0200, Ferry Toth wrote:
This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4.
Prerequisite revert for the reverting of the original commit f49449fbc21e.
Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment") Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Reported-by: Ferry Toth fntoth@gmail.com Cc: stable@vger.kernel.org
drivers/usb/gadget/function/u_ether.c | 2 -- 1 file changed, 2 deletions(-)
You have to sign-off on your changes, otherwise the tools will reject them (as will I). Please fix up for both of these and resend.
Oops, I knew that. Just didn't notice SoB wasn't auto added. I'll that up, sorry.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org