On Fri, Apr 18, 2025 at 02:11:44PM +0200, Ingo Molnar wrote:
No, it doesn't really 'need' a stable tag, it has a Fixes tag already, which gets processed by the -stable team.
Last time I asked Greg, he said they scan for those tags but it doesn't hurt to Cc stable as it helps.
Greg?
Also, the bug is old, 1.5 years old:
Date: Sat, 2 Dec 2023 12:50:23 +0100
plus the erratum is a perf-counters information quality bug affecting what appears to be a limited number of models, with the workaround
No, the fix is needed because Zen2 and newer won't set MSR_K7_HWCR_IRPERF_EN_BIT. It needs to go everywhere.
likely incorporated in BIOS updates as well.
You can very much forget that argument. I have hard BIOS adoption data which paints an abysmal picture. So NEVER EVER rely on BIOS to do anything. Especially for Zen1 which is oooold in BIOS time.
Leave it up to the -stable team whether they think it's severe enough to backport it?
No, they leave it to us section maintainers to decide AFAIK.
Thx.
* Borislav Petkov bp@alien8.de wrote:
plus the erratum is a perf-counters information quality bug affecting what appears to be a limited number of models, with the workaround
No, the fix is needed because Zen2 and newer won't set MSR_K7_HWCR_IRPERF_EN_BIT. It needs to go everywhere.
Fair enough - the current version already has Cc: stable:
263e55949d89 x86/cpu/amd: Fix workaround for erratum 1054
...
Fixes: 232afb557835 ("x86/CPU/AMD: Add X86_FEATURE_ZEN1") Signed-off-by: Sandipan Das sandipan.das@amd.com Signed-off-by: Ingo Molnar mingo@kernel.org Acked-by: Borislav Petkov bp@alien8.de Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/caa057a9d6f8ad579e2f1abaa71efbd5bd4eaf6d.174495646...
Thanks,
Ingo
On Fri, Apr 18, 2025 at 02:37:13PM +0200, Borislav Petkov wrote:
On Fri, Apr 18, 2025 at 02:11:44PM +0200, Ingo Molnar wrote:
No, it doesn't really 'need' a stable tag, it has a Fixes tag already, which gets processed by the -stable team.
NOOOOOO!!!!
Last time I asked Greg, he said they scan for those tags but it doesn't hurt to Cc stable as it helps.
Greg?
Fixes: is a "best effort if we get around to it because a maintainer forgot to put an actual cc: stable tag on it".
As the documentation has stated, since the start of the stable kernel tree work, use a cc: stable tag if you want it to go to a stable tree. Fixes came years later and we are forced to dig through them occasionally because people forget. But you do NOT get a FAILED email if the commit does not apply to a stable tree, and sometimes we just ignore them entirely if we are busy with other stuff.
So please ALWAYS use cc: stable@ on patches you know you want to be applied to stable trees. Use the Fixes: tag to tell us how far back to backport them. That's it. Use both.
thanks,
greg k-h
* Greg KH gregkh@linuxfoundation.org wrote:
On Fri, Apr 18, 2025 at 02:37:13PM +0200, Borislav Petkov wrote:
On Fri, Apr 18, 2025 at 02:11:44PM +0200, Ingo Molnar wrote:
No, it doesn't really 'need' a stable tag, it has a Fixes tag already, which gets processed by the -stable team.
NOOOOOO!!!!
Noted!! :-)
So please ALWAYS use cc: stable@ on patches you know you want to be applied to stable trees. Use the Fixes: tag to tell us how far back to backport them. That's it. Use both.
Undertood!
Thanks,
Ingo
linux-stable-mirror@lists.linaro.org
-
Borislav Petkov -
Greg KH -
Ingo Molnar