Re: [PATCH] rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send()

On Fri, Apr 25, 2025 at 11:36:24AM +0530, Naresh Kamboju wrote:

On Wed, 23 Apr 2025 at 22:52, Dan Carpenter dan.carpenter@linaro.org wrote:

...

The "ret" variable isn't initialized if we don't enter the loop. For example, if "channel->state" is not SMD_CHANNEL_OPENED.

Fixes: 33e3820dda88 ("rpmsg: smd: Use spinlock in tx path") Signed-off-by: Dan Carpenter dan.carpenter@linaro.org

---

Naresh, could you test this patch and see if it fixes the boot problems you saw?

Dan, This patch fixes the reported problem.

Tested-by: Naresh Kamboju naresh.kamboju@linaro.org

Thanks Naresh,

I left off your reported by tag as well.

Reported-by: Linux Kernel Functional Testing lkft@linaro.org

regards, dan carpenter