Re: [PATCH] USB: serial: cyberjack: fix write-URB completion race

On Wed, Oct 28, 2020 at 10:38:27AM +0100, Greg Kroah-Hartman wrote:

On Mon, Oct 26, 2020 at 09:25:48AM +0100, Johan Hovold wrote:

...

The write-URB busy flag was being cleared before the completion handler was done with the URB, something which could lead to corrupt transfers due to a racing write request if the URB is resubmitted.

Fixes: 507ca9bc0476 ("[PATCH] USB: add ability for usb-serial drivers to determine if their write urb is currently being used.") Cc: stable stable@vger.kernel.org # 2.6.13 Signed-off-by: Johan Hovold johan@kernel.org

---

drivers/usb/serial/cyberjack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org

Thanks, applied for 5.10-rc.

Johan